Fix corrupted record counter in SequenceFileReader.Offset.increment()#8440
Merged
Conversation
Signed-off-by: Julien Nioche <julien@digitalpebble.com>
rzo1
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In SequenceFileReader.Offset.increment(), line 204 overwrites
currentRecord(a record counter) withnewBytePosition(a byte offset), immediately after incrementing it on line 202:This is a copy-paste error:
currentRecordshould becurrRecordEndOffset.Impact
Every call to next() replaces the record counter with the reader's byte position. This corrupts: