STORM-4142 Log when falling back to java serialization#3824
Merged
Conversation
Contributor
Author
|
Also, I am using storm version 2.3.0. Should I raise separate PR with base branch as 2.3.x for me to use these changes? |
Contributor
Author
11:58:39.239 [Thread-39-1-executor[1, 1]] WARN o.a.s.s.DefaultKryoFactory - Class is not registered: org.example.TestClass |
Contributor
|
@MaheshAravindV Thanks for the PR. You do not need to do a backport - we are not planning to do any official releases from the 2.3.x series. If you need it, you can have a look at the GH actions building the nightlies and build a custom 2.3.x distribution with your patch. |
rzo1
approved these changes
Jan 1, 2025
reiabreu
approved these changes
Jan 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Falling back to java serialization should be a last resort and devs should have some warning when this happens.
How was the change tested
Not sure if tests are needed for log change. Can add if required.