STORM-4131: Update log4j2 to a non-borked version#3807
Merged
Conversation
Contributor
|
We can even delete all references in SC to log4j2 as we get it from Storm anway. |
reiabreu
approved these changes
Dec 6, 2024
rzo1
approved these changes
Dec 6, 2024
Contributor
|
Do you mind creating a JIRA issue for this so we can link it to the PR?
Thank you
…On Fri, Dec 6, 2024, 18:52 Richard Zowalla ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#3807 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAG5GIUX5BEM4SQUZVYN23D2EHP7DAVCNFSM6AAAAABTFBPWU6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIOBVGUZTQOJXGU>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
update log4j2 to avoid serious problems with 2.24.1 --- apache/logging-log4j2#3143
How was the change tested
mvn testfailed locally, but not likely because of this change. I got a clean build on the second attempt. 🤷