STORM-4106 Fix Storm.ps1 stdout/stderr feedback in Powershell ISE#3740
Merged
rzo1 merged 1 commit intoNov 11, 2024
Merged
Conversation
rzo1
approved these changes
Nov 11, 2024
rzo1
left a comment
Contributor
There was a problem hiding this comment.
Not a windows user but change looks ok (after checking on & and how python is now called directly)
Author
|
Thanks @rzo1, incidentally, the & operator to call python3 directly is already being used in Storm.ps1 to check the version of python installed - see line 26: |
Contributor
|
Apologies @Scomocouk @rzo1 , meant to review this one. Cheers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Addresses STORM-4106. Stdout\Stderr feedback when launching Storm.ps1 in Powershell ISE now works with this change
Feedback from regular Powershell cmd prompt continues to work with this fix too.
How was the change tested
Open Powershell ISE and run Storm.ps1 to run a command (e..g show usage with ./storm1.ps1 -h)
Before the fix the Powershell ISE returns nothing output from Storm.ps1
With this fix the output Storm.ps1 is seen in Powershell ISE command window (and continues to be seen in regular Powershell cmd prompt)
See attached screenshots from before and after fix for both Powershell ISE and regular Powershell command prompts
Before Fix
After Fix
