STORM-4144 - Bump slf4j.version from 1.7.36 to 2.0.16#3680
Merged
Conversation
Contributor
|
I think we can make the move to SLF4J2 but need to carefully review transient libraries and update exclusions due to the change of provider discovery in SLFJ42. What do you think @agresch ? Any objections? If not, I might take a look in the near future. |
Contributor
|
@dependabot rebase |
85ac4d4 to
da2731d
Compare
Contributor
|
@dependabot rebase |
da2731d to
735ce76
Compare
Contributor
|
@dependabot recreate |
735ce76 to
2b2ed60
Compare
Contributor
Contributor
|
https://github.com/dependabot recreate |
Bumps `slf4j.version` from 1.7.36 to 2.0.16. Updates `org.slf4j:slf4j-api` from 1.7.36 to 2.0.16 Updates `org.slf4j:slf4j-log4j12` from 1.7.36 to 2.0.16 Updates `org.slf4j:log4j-over-slf4j` from 1.7.36 to 2.0.16 Updates `org.slf4j:jcl-over-slf4j` from 1.7.36 to 2.0.16 Updates `org.slf4j:jul-to-slf4j` from 1.7.36 to 2.0.16 --- updated-dependencies: - dependency-name: org.slf4j:slf4j-api dependency-type: direct:production update-type: version-update:semver-major - dependency-name: org.slf4j:slf4j-log4j12 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: org.slf4j:log4j-over-slf4j dependency-type: direct:development update-type: version-update:semver-major - dependency-name: org.slf4j:jcl-over-slf4j dependency-type: direct:production update-type: version-update:semver-major - dependency-name: org.slf4j:jul-to-slf4j dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
2b2ed60 to
6a71296
Compare
Contributor
|
How do you expect it to affect the consumers?
…On Sun, 5 Jan 2025 at 09:04, Richard Zowalla ***@***.***> wrote:
@reiabreu <https://github.com/reiabreu> @jnioche
<https://github.com/jnioche> Any thoughts on this one? I think, that it
should be fine to do this upgrade but it will certainly affect consumers.
—
Reply to this email directly, view it on GitHub
<#3680 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAG5GIWJH5Z4XDRK5IQIZND2JDYSFAVCNFSM6AAAAABMXATAYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZRGU2TIMJUGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
|
Slf4j2 using another binding mechanismn for the log implementation. Some people do shading before submitting a topology, so if you have for example the wrong log4j2-slf4j binding in your configuring, you might end without logging. Although, people should actually use it as provided Dependency, so perhaps it won't be a big deal. |
reiabreu
approved these changes
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
slf4j.versionfrom 1.7.36 to 2.0.16.Updates
org.slf4j:slf4j-apifrom 1.7.36 to 2.0.16Updates
org.slf4j:slf4j-log4j12from 1.7.36 to 2.0.16Updates
org.slf4j:log4j-over-slf4jfrom 1.7.36 to 2.0.16Updates
org.slf4j:jcl-over-slf4jfrom 1.7.36 to 2.0.16Updates
org.slf4j:jul-to-slf4jfrom 1.7.36 to 2.0.16You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)