Skip to content

Conversation

@falaki
Copy link
Contributor

@falaki falaki commented Jul 30, 2015

This PR adds synonyms for merge and summary in SparkR DataFrame API.

cc @shivaram

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we also add merge here?

@SparkQA
Copy link

SparkQA commented Jul 30, 2015

Test build #39109 has finished for PR 7806 at commit fc01f2d.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class DateAdd(startDate: Expression, days: Expression)
    • case class DateSub(startDate: Expression, days: Expression)
    • case class TimeAdd(start: Expression, interval: Expression)
    • case class TimeSub(start: Expression, interval: Expression)
    • case class AddMonths(startDate: Expression, numMonths: Expression)
    • case class MonthsBetween(date1: Expression, date2: Expression)

@SparkQA
Copy link

SparkQA commented Jul 31, 2015

Test build #39135 has finished for PR 7806 at commit e8eb86f.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 31, 2015

Test build #39293 has finished for PR 7806 at commit 72600f7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shivaram
Copy link
Contributor

shivaram commented Aug 1, 2015

Thanks @falaki -- LGTM. Merging this

@asfgit asfgit closed this in 712f5b7 Aug 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants