Skip to content

[SPARK-9324][SPARK-9322][SPARK-9321][SPARKR] Some aliases for R-like functions in DataFrames #7764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
falaki wants to merge 6 commits into from
Closed

[SPARK-9324][SPARK-9322][SPARK-9321][SPARKR] Some aliases for R-like functions in DataFrames #7764

falaki wants to merge 6 commits into from

Conversation

@falaki
Copy link
Contributor

@falaki falaki commented Jul 30, 2015

Adds following aliases:

  • unique (distinct)
  • rbind (unionAll): accepts many DataFrames
  • nrow (count)
  • ncol
  • dim
  • names (columns): along with the replacement function to change names

@SparkQA
Copy link

SparkQA commented Jul 30, 2015

Test build #38941 has finished for PR 7764 at commit d9307f8.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

shivaram
shivaram reviewed Jul 30, 2015
View reviewed changes
R/pkg/R/DataFrame.R Outdated
Copy link
Contributor

@shivaram shivaram Jul 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: number of

@shivaram
Copy link
Contributor

shivaram commented Jul 30, 2015

Jenkins, retest this please

@SparkQA
Copy link

SparkQA commented Jul 31, 2015

Test build #39123 has finished for PR 7764 at commit 5e4a4d0.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shivaram
Copy link
Contributor

shivaram commented Jul 31, 2015

@falaki the documentation builds are failing with an error message

Error : /home/jenkins/workspace/SparkPullRequestBuilder@2/R/pkg/man/nrow.Rd: Sections \title, and \name must exist and be unique in Rd files

@SparkQA
Copy link

SparkQA commented Jul 31, 2015

Test build #39266 has finished for PR 7764 at commit 56016f5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

shivaram
shivaram reviewed Jul 31, 2015
View reviewed changes
R/pkg/R/DataFrame.R
Copy link
Contributor

@shivaram shivaram Jul 31, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theres an extra line of space before this setMethod, but I can fix this up during merge

@shivaram
Copy link
Contributor

shivaram commented Jul 31, 2015

Thanks @falaki for the update. LGTM. I had a minor style fix that I'll apply during the merge.

@asfgit asfgit closed this in 710c2b5 Jul 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@falaki @SparkQA @shivaram