Skip to content

[SPARK-9268] [ml] Removed varargs annotation from Params.setDefault taking multiple params #7604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jkbradley wants to merge 1 commit into from
Closed

[SPARK-9268] [ml] Removed varargs annotation from Params.setDefault taking multiple params #7604

jkbradley wants to merge 1 commit into from

Conversation

@jkbradley
Copy link
Member

@jkbradley jkbradley commented Jul 23, 2015

Removed varargs annotation from Params.setDefault taking multiple params.

Though varargs is technically correct, it often requires that developers do clean assembly, rather than (not clean) assembly, which is a nuisance during development.

CC: @mengxr

@mengxr
Copy link
Contributor

mengxr commented Jul 23, 2015

LGTM if MiMa doesn't complain.

@SparkQA
Copy link

SparkQA commented Jul 23, 2015

Test build #38134 has finished for PR 7604 at commit 6016dc6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class CreateArray(children: Seq[Expression]) extends Expression
    • case class CreateStruct(children: Seq[Expression]) extends Expression
    • case class CreateNamedStruct(children: Seq[Expression]) extends Expression

@mengxr
Copy link
Contributor

mengxr commented Jul 23, 2015

Merged into master. Thanks!

@asfgit asfgit closed this in 410dd41 Jul 23, 2015
@jkbradley jkbradley deleted the params-setdefault-varargs branch July 23, 2015 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jkbradley @mengxr @SparkQA