[SPARK-4366] [SQL] [Follow-up] Fix SqlParser compiling warning. #7588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
There was a problem hiding this comment.
Since we can register a UDAF and use DISTINCT with it, we can just create an UnresolvedFunction at here. If it is actually a built-in aggregate function and it does not support DISTINCT, we will throw an error later.
|
Test build #38047 has finished for PR 7588 at commit
|
Contributor
Author
|
test this please. |
|
Test build #38054 has finished for PR 7588 at commit
|
Contributor
Author
|
test this please |
|
Test build #38076 has finished for PR 7588 at commit
|
|
Test build #1167 has finished for PR 7588 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.