Skip to content

[SPARK-9121][SparkR] Get rid of the warnings about no visible global function definition in SparkR #7567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yu-iskw wants to merge 4 commits into from
Closed

[SPARK-9121][SparkR] Get rid of the warnings about no visible global function definition in SparkR #7567

yu-iskw wants to merge 4 commits into from

Conversation

@yu-iskw
Copy link
Contributor

@yu-iskw yu-iskw commented Jul 21, 2015

@SparkQA
Copy link

SparkQA commented Jul 21, 2015

Test build #37939 has finished for PR 7567 at commit 3a5e0ab.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

shivaram
shivaram reviewed Jul 21, 2015
View reviewed changes
R/pkg/inst/tests/test_sparkSQL.R Outdated
Copy link
Contributor

@shivaram shivaram Jul 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to do this -- instead we can include library(testthat) in our lint-R script as Jenkins and developers who run unit tests should have this package installed.

Copy link
Contributor Author

@yu-iskw yu-iskw Jul 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. I will modify it soon. Thank you for the comment.

shivaram
shivaram reviewed Jul 22, 2015
View reviewed changes
dev/lint-r.R Outdated
Copy link
Contributor

@shivaram shivaram Jul 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing -- it would be good for the script to exit if any of these package loads fail. We can pass in logical.return=T to the library call to do this.

Copy link
Contributor Author

@yu-iskw yu-iskw Jul 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I have added the validation.

@SparkQA
Copy link

SparkQA commented Jul 22, 2015

Test build #38002 has finished for PR 7567 at commit b1f19ed.

  • This patch fails some tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yu-iskw
Copy link
Contributor Author

yu-iskw commented Jul 22, 2015

Jenkins, test this please.

shivaram
shivaram reviewed Jul 22, 2015
View reviewed changes
dev/lint-r.R Outdated
Copy link
Contributor

@shivaram shivaram Jul 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo here -- It should be install-dev.sh

Copy link
Contributor Author

@yu-iskw yu-iskw Jul 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry...

@SparkQA
Copy link

SparkQA commented Jul 22, 2015

Test build #37997 has finished for PR 7567 at commit 1a03987.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shivaram
Copy link
Contributor

shivaram commented Jul 22, 2015

LGTM. Thanks @yu-iskw

@SparkQA
Copy link

SparkQA commented Jul 22, 2015

Test build #46 has finished for PR 7567 at commit b1f19ed.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shivaram
Copy link
Contributor

shivaram commented Jul 22, 2015

Jenkins, retest this please

@SparkQA
Copy link

SparkQA commented Jul 22, 2015

Test build #38003 has finished for PR 7567 at commit b1f19ed.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 22, 2015

Test build #38009 timed out for PR 7567 at commit c8cfd63 after a configured wait of 175m.

@SparkQA
Copy link

SparkQA commented Jul 22, 2015

Test build #38020 has finished for PR 7567 at commit c8cfd63.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shivaram
Copy link
Contributor

shivaram commented Jul 22, 2015

Finally the tests passed ! Merging this.

@shivaram shivaram mentioned this pull request Jul 22, 2015
Closed
@asfgit asfgit closed this in 63f4bcc Jul 22, 2015
@yu-iskw
Copy link
Contributor Author

yu-iskw commented Jul 22, 2015

@shivaram Thank you for reviewing it and merging it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yu-iskw @SparkQA @shivaram