Skip to content

[SPARK-9165][SQL] codegen for CreateArray, CreateStruct and CreateNamedStruct #7537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yjshen wants to merge 3 commits into from
Closed

[SPARK-9165][SQL] codegen for CreateArray, CreateStruct and CreateNamedStruct #7537

yjshen wants to merge 3 commits into from

Conversation

@yjshen
Copy link
Member

@yjshen yjshen commented Jul 20, 2015

@yjshen yjshen force-pushed the array_struct_codegen branch from 3191341 to 39cefb8 Compare July 20, 2015 14:14
@yjshen
Copy link
Member Author

yjshen commented Jul 20, 2015

/cc @rxin

@SparkQA
Copy link

SparkQA commented Jul 21, 2015

Test build #1133 has finished for PR 7537 at commit 39cefb8.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

marmbrus
marmbrus reviewed Jul 21, 2015
View reviewed changes
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ComplexTypeSuite.scala
Copy link
Contributor

@marmbrus marmbrus Jul 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a test that includes null values?

Copy link
Member Author

@yjshen yjshen Jul 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added below.

@yjshen
Copy link
Member Author

yjshen commented Jul 21, 2015

Thanks @marmbrus , I would update my code soon.

@yjshen yjshen force-pushed the array_struct_codegen branch from 695ed31 to 5e90f0a Compare July 21, 2015 06:46
@SparkQA
Copy link

SparkQA commented Jul 21, 2015

Test build #1142 has finished for PR 7537 at commit 39cefb8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class CreateArray(children: Seq[Expression]) extends Expression
    • case class CreateStruct(children: Seq[Expression]) extends Expression
    • case class CreateNamedStruct(children: Seq[Expression]) extends Expression

marmbrus
marmbrus reviewed Jul 21, 2015
View reviewed changes
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ComplexTypeSuite.scala Outdated
Copy link
Contributor

@marmbrus marmbrus Jul 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to nit-pick, but what is happening here is kind of confusing:

scala> List(1,2).+:(null)
res0: List[Any] = List(null, 1, 2)

Perhaps just use infix notation for operators:

scala> List(1,2) :+ null
res1: List[Any] = List(1, 2, null)

@asfgit asfgit closed this in 86f80e2 Jul 22, 2015
@marmbrus
Copy link
Contributor

marmbrus commented Jul 22, 2015

Thanks! Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yjshen @SparkQA @marmbrus