[SPARK-52548][CORE][TESTS] Add a test case for when shuffle manager is overridden by a SparkPlugin #51246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… overridden by a SparkPlugin
yaooqinn
reviewed
Jun 24, 2025
core/src/test/scala/org/apache/spark/internal/plugin/PluginContainerSuite.scala
Outdated
Show resolved
Hide resolved
…tainerSuite.scala
Member
|
Merged to master, thank you @zhztheplayer |
Member
Author
|
Thanks for reviewing! @yaooqinn |
| override def driverPlugin(): DriverPlugin = { | ||
| new DriverPlugin { | ||
| override def init(sc: SparkContext, ctx: PluginContext): JMap[String, String] = { | ||
| sc.conf.set(SHUFFLE_MANAGER, classOf[MyShuffleManager].getName) |
Member
There was a problem hiding this comment.
Interesting. Does this DriverPlugin also guarantee Executor-side shuffle manager, @zhztheplayer ?
Member
Author
There was a problem hiding this comment.
I think so, the configuration modification here should always take effect on executors, similar practices are adopted a lot in our use case. I haven't set up a real cluster to test this specific option though.
Member
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Thank you for adding this test coverage, @zhztheplayer .
Member
|
+1, late LGTM. |
Member
Author
No problem. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As title, adding a test case for when shuffle manager is overridden by a SparkPlugin.
Why are the changes needed?
PR #43627 introduced a change to allow the shuffle manager specified in Spark configuration to be overridden in SparkPlugin, this change was not guarded by test though.
The change in PR #43627 also allows Spark plugins to configure a shuffle manager automatically for user, so user won't have to configure both
spark.pluginsandspark.shuffle.managerat the same time.Does this PR introduce any user-facing change?
No.
Was this patch authored or co-authored using generative AI tooling?
No.