Skip to content

[SPARK-50232][PYTHON][CONNECT] Add 'protobuf==5.28.3' in dev/requirements.txt#48763

Closed
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
HyukjinKwon:note-protobuf
Closed

[SPARK-50232][PYTHON][CONNECT] Add 'protobuf==5.28.3' in dev/requirements.txt#48763
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
HyukjinKwon:note-protobuf

Conversation

@HyukjinKwon
Copy link
Copy Markdown
Member

@HyukjinKwon HyukjinKwon commented Nov 5, 2024

What changes were proposed in this pull request?

This PR proposes to add 'protobuf==5.28.3' in dev/requirements.txt. If you have an old version in your env, you would face an error like:

google.protobuf.runtime_version.VersionError: Detected incompatible Protobuf Gencode/Runtime versions when loading spark/connect/base.proto: gencode 5.28.3 runtime 5.28.2. Runtime version cannot be older than the linked gencode version. See Protobuf version guarantees at https://protobuf.dev/support/cross-version-runtime-guarantee.

This PR is a sort of a followup of #48644

Why are the changes needed?

So developers can easily set up their env.

Does this PR introduce any user-facing change?

No, dev-only.

How was this patch tested?

Manually installed and tested.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the BUILD label Nov 5, 2024
@HyukjinKwon
Copy link
Copy Markdown
Member Author

Merged to master.

Copy link
Copy Markdown
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, late LGTM.

@dongjoon-hyun
Copy link
Copy Markdown
Member

Thank you, @HyukjinKwon and @zhengruifeng .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants