Skip to content

[SPARK-50143][BUILD] Fix protobuf module Maven compilation#48673

Closed
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-50143
Closed

[SPARK-50143][BUILD] Fix protobuf module Maven compilation#48673
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-50143

Conversation

@dongjoon-hyun
Copy link
Copy Markdown
Member

@dongjoon-hyun dongjoon-hyun commented Oct 28, 2024 •
edited
Loading

What changes were proposed in this pull request?

This PR aims to fix protobuf module Maven compilation failure due to the following protocol-jar-maven-plugin bug.

Note that this happens only at Maven compilation.

Why are the changes needed?

BEFORE

$ build/mvn -DskipTests clean install -pl connector/protobuf -e -am
...
[INFO] Spark Protobuf ..................................... FAILURE [  7.295 s]
...
[ERROR] Failed to execute goal com.github.os72:protoc-jar-maven-plugin:3.11.4:run (default) on project spark-protobuf_2.13: Execution default of goal com.github.os72:protoc-jar-maven-plugin:3.11.4:run failed:
Cannot read the array length because "<local6>" is null

AFTER

$ build/mvn -DskipTests clean install -pl connector/protobuf -e -am
...
[INFO] Reactor Summary for Spark Project Parent POM 4.0.0-SNAPSHOT:
[INFO]
[INFO] Spark Project Parent POM ........................... SUCCESS [  2.601 s]
[INFO] Spark Project Tags ................................. SUCCESS [  5.234 s]
[INFO] Spark Project Sketch ............................... SUCCESS [  5.278 s]
[INFO] Spark Project Common Utils ......................... SUCCESS [ 14.695 s]
[INFO] Spark Project Local DB ............................. SUCCESS [  6.258 s]
[INFO] Spark Project Networking ........................... SUCCESS [  9.384 s]
[INFO] Spark Project Shuffle Streaming Service ............ SUCCESS [  7.761 s]
[INFO] Spark Project Variant .............................. SUCCESS [  3.304 s]
[INFO] Spark Project Unsafe ............................... SUCCESS [  8.677 s]
[INFO] Spark Project Connect Shims ........................ SUCCESS [  2.690 s]
[INFO] Spark Project Launcher ............................. SUCCESS [  5.618 s]
[INFO] Spark Project Core ................................. SUCCESS [01:11 min]
[INFO] Spark Project SQL API .............................. SUCCESS [ 21.759 s]
[INFO] Spark Project Catalyst ............................. SUCCESS [01:30 min]
[INFO] Spark Project SQL .................................. SUCCESS [01:53 min]
[INFO] Spark Protobuf ..................................... SUCCESS [ 18.285 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  06:26 min
[INFO] Finished at: 2024-10-27T21:01:12-07:00
[INFO] ------------------------------------------------------------------------

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Manually run the following command like I did in the above.

$ build/mvn -DskipTests clean install -pl connector/protobuf -e -am

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun dongjoon-hyun mentioned this pull request Oct 28, 2024
Closed
@dongjoon-hyun
Copy link
Copy Markdown
Member Author

dongjoon-hyun commented Oct 28, 2024

cc @LuciferYang

@dongjoon-hyun dongjoon-hyun marked this pull request as draft October 28, 2024 03:53
@dongjoon-hyun
Copy link
Copy Markdown
Member Author

dongjoon-hyun commented Oct 28, 2024

I verified that this works, @LuciferYang . Could you review this please?

@dongjoon-hyun dongjoon-hyun marked this pull request as ready for review October 28, 2024 04:02
@dongjoon-hyun
Copy link
Copy Markdown
Member Author

dongjoon-hyun commented Oct 28, 2024 •
edited
Loading

Also, cc @viirya . Could you help me by reviewing this?

@dongjoon-hyun
Copy link
Copy Markdown
Member Author

dongjoon-hyun commented Oct 28, 2024

Could you review this PR, @zhengruifeng ?

@dongjoon-hyun
Copy link
Copy Markdown
Member Author

dongjoon-hyun commented Oct 28, 2024

Thank you so much, @zhengruifeng !

@dongjoon-hyun
Copy link
Copy Markdown
Member Author

dongjoon-hyun commented Oct 28, 2024

Merged to master to recover Maven CIs.

I'll monitor those CIs after merging this.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-50143 branch October 28, 2024 04:45
@LuciferYang
Copy link
Copy Markdown
Contributor

LuciferYang commented Oct 28, 2024

late LGTM

@dongjoon-hyun
Copy link
Copy Markdown
Member Author

dongjoon-hyun commented Oct 28, 2024

Thank you for reporting and reviewing, @LuciferYang .

@panbingkun
Copy link
Copy Markdown
Contributor

panbingkun commented Oct 28, 2024

late LGTM

viirya
viirya reviewed Oct 28, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dongjoon-hyun
Copy link
Copy Markdown
Member Author

dongjoon-hyun commented Oct 28, 2024

Thank you, @panbingkun and @viirya .

@dongjoon-hyun
Copy link
Copy Markdown
Member Author

dongjoon-hyun commented Oct 28, 2024 •
edited
Loading

For the record, Maven CI becomes healthy back after this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viirya viirya viirya left review comments

@zhengruifeng zhengruifeng zhengruifeng approved these changes

Assignees

No one assigned

Labels

BUILD PROTOBUF

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dongjoon-hyun @LuciferYang @panbingkun @viirya @zhengruifeng