[SPARK-47689][SQL][FOLLOWUP] More accurate file path in TASK_WRITE_FAILED error#45844
Closed
cloud-fan wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-47689][SQL][FOLLOWUP] More accurate file path in TASK_WRITE_FAILED error#45844cloud-fan wants to merge 1 commit intoapache:masterfrom
cloud-fan wants to merge 1 commit intoapache:masterfrom
Conversation
88be7d3 to
e79c5a8
Compare
Contributor
Author
|
cc @HyukjinKwon |
HyukjinKwon
approved these changes
Apr 4, 2024
Contributor
Author
|
the docker integration test failure is unrelated, thanks for the review, merging to master! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up of #45797 . Instead of detecting query execution errors and not wrapping them, it's better to do the error wrapping only in the data writer, which has more context. We can provide the specific file path when the error happened, instead of the destination directory name.
Why are the changes needed?
better error message
Does this PR introduce any user-facing change?
no
How was this patch tested?
updated tests
Was this patch authored or co-authored using generative AI tooling?
No