[SPARK-46658][DOCS] Loosen Ruby dependency specification#44667
Closed
nchammas wants to merge 4 commits intoapache:masterfrom
Closed
[SPARK-46658][DOCS] Loosen Ruby dependency specification#44667nchammas wants to merge 4 commits intoapache:masterfrom
nchammas wants to merge 4 commits intoapache:masterfrom
Conversation
Contributor
Author
|
cc @HyukjinKwon @srowen - We should update the build images to include Ruby 3. spark/dev/create-release/spark-rm/Dockerfile Lines 84 to 85 in 11ac856 Lines 59 to 60 in 4957c1a I would do this myself, but non-committers cannot really test changes to these images fully. |
HyukjinKwon
approved these changes
Jan 11, 2024
Member
|
Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As promised here, this change loosens our Ruby dependency specification so that Bundler can update transitive dependencies more easily.
Other changes included:
We can still build our docs using Ruby 2.7, but we should push devs to install Ruby 3 since Ruby 2 is EOL and we are unable to upgrade some of our doc dependencies until we're running Ruby 3.
Why are the changes needed?
Make the document building process more robust to future updates coming from the Ruby ecosystem.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
I built and reviewed the docs on both Ruby 2.7.8 and Ruby 3.3.0 using the following command:
SKIP_SCALADOC=1 SKIP_PYTHONDOC=1 SKIP_RDOC=1 bundle exec jekyll buildWas this patch authored or co-authored using generative AI tooling?
No.