[SPARK-45564][SQL] Simplify 'DataFrameStatFunctions.bloomFilter' with 'BloomFilterAggregate' expression#43391
Closed
zhengruifeng wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
Contributor
|
cc @hvanhovell |
Contributor
srowen
reviewed
Oct 17, 2023
Member
srowen
left a comment
There was a problem hiding this comment.
If there's no behavior change other than the exception type, and its' not slower, seems fine.
Member
|
Merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Simplify 'DataFrameStatFunctions.bloomFilter' function with 'BloomFilterAggregate' expression
Why are the changes needed?
existing implementation was based on RDD, and it can be simplified by dataframe operations
Does this PR introduce any user-facing change?
when the input parameters or datatypes are invalid, throw
AnalysisExceptioninstead ofIllegalArgumentExceptionHow was this patch tested?
ci
Was this patch authored or co-authored using generative AI tooling?
no