[SPARK-44536][BUILD] Upgrade sbt to 1.9.3#42141
Closed
panbingkun wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-44536][BUILD] Upgrade sbt to 1.9.3#42141panbingkun wants to merge 2 commits intoapache:masterfrom
panbingkun wants to merge 2 commits intoapache:masterfrom
Conversation
yaooqinn
approved these changes
Jul 25, 2023
LuciferYang
approved these changes
Jul 25, 2023
HyukjinKwon
approved these changes
Jul 25, 2023
Member
|
Can you try tests again? |
Contributor
Author
Done. |
Contributor
|
Merge into master. Thanks @panbingkun @HyukjinKwon @dongjoon-hyun @yaooqinn and @srowen |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to upgrade sbt from 1.9.2 to 1.9.3.
Why are the changes needed?
1.The new version brings some improvment:
Actionable diagnostics (aka quickfix)
Actionable diagnostics, or quickfix, is an area in Scala tooling that's been getting attention since Chris Kipp presented it in the March 2023 Tooling Summit. Chris has written the roadmap and sent sbt/sbt#7242 that kickstarted the effort, but now there's been steady progress in build-server-protocol/build-server-protocol#527, scala/scala3#17337, scala/scala#10406, IntelliJ, Zinc, etc. Metals 1.0.0, for example, is now capable of surfacing code actions as a quickfix.
sbt 1.9.3 adds a new interface called AnalysisCallback2 to relay code actions from the compiler(s) to Zinc's Analysis file. Future version of Scala 2.13.x (and hopefully Scala 3) will release with proper code actions, but as a demo I've implemented a code action for procedure syntax usages even on current Scala 2.13.11 with -deprecation flag.
2.Full release notes:
https://github.com/sbt/sbt/releases/tag/v1.9.3
3.v1.9.2 VS v1.9.3
sbt/sbt@v1.9.2...v1.9.3
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.