Skip to content

[SPARK-13296][SQL] Move UserDefinedFunction into sql.expressions. #11181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rxin wants to merge 6 commits into from
Closed

[SPARK-13296][SQL] Move UserDefinedFunction into sql.expressions. #11181

rxin wants to merge 6 commits into from

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Feb 12, 2016

This pull request has the following changes:

  1. Moved UserDefinedFunction into expressions package. This is more consistent with how we structure the packages for window functions and UDAFs.
  2. Moved UserDefinedPythonFunction into execution.python package, so we don't have a random private class in the top level sql package.
  3. Move everything in execution/python.scala into the newly created execution.python package.

Most of the diffs are just straight copy-paste.

Test

@rxin
Copy link
Contributor Author

rxin commented Feb 12, 2016

mima will probably fail

@SparkQA
Copy link

SparkQA commented Feb 12, 2016

Test build #51179 has finished for PR 11181 at commit 1a42847.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

rxin
rxin reviewed Feb 12, 2016
View reviewed changes
sql/core/src/main/scala/org/apache/spark/sql/execution/python/BatchPythonEvaluation.scala Outdated
Copy link
Contributor Author

@rxin rxin Feb 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is just a simple copy/paste from python.scala.

@SparkQA
Copy link

SparkQA commented Feb 12, 2016

Test build #51180 has finished for PR 11181 at commit 2911532.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Feb 12, 2016

Test build #51198 has finished for PR 11181 at commit 6c8058b.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Feb 12, 2016

Test build #51202 has finished for PR 11181 at commit 66b448d.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor Author

rxin commented Feb 13, 2016

cc @davies for review

@SparkQA
Copy link

SparkQA commented Feb 13, 2016

Test build #51222 has finished for PR 11181 at commit c268740.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Feb 13, 2016

Test build #51231 has finished for PR 11181 at commit 913bf1b.

  • This patch fails from timeout after a configured wait of 250m.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor Author

rxin commented Feb 14, 2016

@davies this did pass tests - just some lingering thing that made the timeout.

@davies
Copy link
Contributor

davies commented Feb 14, 2016

LGTM

@davies
Copy link
Contributor

davies commented Feb 14, 2016

BTW, these movement will make us harder to find out the history of the changes, i'd like to not do that if it's not too bad.

@SparkQA
Copy link

SparkQA commented Feb 14, 2016

Test build #2539 has finished for PR 11181 at commit 913bf1b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor Author

rxin commented Feb 14, 2016

I've merged this in master.

@asfgit asfgit closed this in 354d4c2 Feb 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rxin @SparkQA @davies