Refactor TLS setup code into a separate file and consolidate logic between the StatefulSet and exporter Deployment #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thelabdude
commented
Aug 17, 2021
thelabdude
commented
Aug 17, 2021
thelabdude
commented
Aug 17, 2021
thelabdude
commented
Aug 17, 2021
thelabdude
commented
Aug 17, 2021
thelabdude
commented
Aug 17, 2021
thelabdude
commented
Aug 17, 2021
…tween the StatefulSet and exporter Deployment
b7e3a8c to
b619b29
Compare
HoustonPutman
approved these changes
Aug 18, 2021
Contributor
HoustonPutman
left a comment
There was a problem hiding this comment.
I really like the new design, this looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #308
Consolidated most of the TLS related utility code into a new file in the
utilpackage:solr_tls_util.goAll the TLS related config (env vars, annotations, initContainers, volumes/mounts) get appended to the config for a
StatefulSetorDeploymentin one step at the end vs. being infused at various places inGenerateStatefulSetandGenerateSolrPrometheusExporterDeployment. I like this approach because most of the TLS config is additive. There are a few places where we have to be careful about overriding previous settings (such as theentrypointfor the exporter when using themountedServerTLSDirbut that's only in a few small places).There's also a lot of common logic for configuring the StatefulSet (for SolrClouds) and Deployment (for exporter), so I refactored the reusable parts into their own method.