SOLR-17319: CompoundQueryComponent scribbles#2597
Draft
cpoerschke wants to merge 5 commits intoapache:mainfrom
Draft
SOLR-17319: CompoundQueryComponent scribbles#2597cpoerschke wants to merge 5 commits intoapache:mainfrom
cpoerschke wants to merge 5 commits intoapache:mainfrom
Conversation
cpoerschke
commented
Jul 26, 2024
|
|
||
| public class CompoundSearchHandler extends SearchHandler { | ||
|
|
||
| protected ResponseBuilder newResponseBuilder( |
Contributor
Author
There was a problem hiding this comment.
https://issues.apache.org/jira/browse/SOLR-13511 added support to allow customisation like this.
cpoerschke
commented
Jul 26, 2024
Comment on lines
+29
to
+35
| ResponseBuilder rb_1 = new ResponseBuilder(rb.req, new SolrQueryResponse(), rb.components); | ||
| rb_1.setQueryString(rb_1.req.getParams().get("rrf.q.1")); | ||
| crb.responseBuilders.add(rb_1); | ||
|
|
||
| ResponseBuilder rb_2 = new ResponseBuilder(rb.req, new SolrQueryResponse(), rb.components); | ||
| rb_2.setQueryString(rb_2.req.getParams().get("rrf.q.2")); | ||
| crb.responseBuilders.add(rb_2); |
Contributor
Author
There was a problem hiding this comment.
QueryComponent.prepare already has support for using other than CommonParams.Q i.e. q parameter for the query: https://github.com/apache/solr/blob/releases/solr/9.6.1/solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java#L174-L181
7 tasks
Contributor
Author
|
#3648 is a continuation of these scribbles here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17319