Enhance Npm Resolver: support recording license contents#71
Merged
kezhenxu94 merged 2 commits intoapache:mainfrom Sep 15, 2021
Merged
Enhance Npm Resolver: support recording license contents#71kezhenxu94 merged 2 commits intoapache:mainfrom
kezhenxu94 merged 2 commits intoapache:mainfrom
Conversation
kezhenxu94
previously approved these changes
Sep 15, 2021
pkg/deps/result.go
Outdated
| LicenseFilePath string | ||
| LicenseContent string | ||
| LicenseSpdxID string | ||
| ManifestFilePath string |
Member
There was a problem hiding this comment.
This seems to be unused now, do you think it will be used any soon?
Contributor
Author
There was a problem hiding this comment.
Nope. The ManifestFilePath field seems redundent. I'm gonna delete this field.
kezhenxu94
approved these changes
Sep 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch eanhances Npm resolver to record each pkg's license contents. In previous versions, Npm resolver will not record the license content when it identifies a pkg's license through the package.json file. Now, it will still resolve a pkg's license info through its package.json file first. Also, whether or not the previous step succeeded, it will try to locate a pkg's LICENSE file and record its content.