Fix file extension conflict between RenderScript and Rust#66
Merged
kezhenxu94 merged 1 commit intoapache:mainfrom Sep 8, 2021
quickwit-inc:guilload--fix-extension-conflict-between-renderscript-and-rust
Merged
Fix file extension conflict between RenderScript and Rust#66kezhenxu94 merged 1 commit intoapache:mainfrom quickwit-inc:guilload--fix-extension-conflict-between-renderscript-and-rust
kezhenxu94 merged 1 commit intoapache:mainfrom
quickwit-inc:guilload--fix-extension-conflict-between-renderscript-and-rust
Conversation
kezhenxu94
approved these changes
Sep 8, 2021
Member
kezhenxu94
left a comment
There was a problem hiding this comment.
That's interesting, thank you @guilload !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
comment_style_idfor Rust was added in #29, but currently, runningheader fixfor Rust files does not work and displaysunsupported files: ....The language configuration file contains two entries for the
.rsfile extension: RenderScript and Rust..rsfiles end up matching RenderScript, which does not have a comment style. Locally, I fixed this for Rust by removing RenderScript from the language configuration file.However, in this PR, I choose to set the command style for RenderScript to double slash, which is supported by both languages (and actually the preferred style for Rust).