add comment type to cython declaration#62
Merged
kezhenxu94 merged 3 commits intoapache:mainfrom Aug 25, 2021
keiranmraine:feature/addCython
Merged
add comment type to cython declaration#62kezhenxu94 merged 3 commits intoapache:mainfrom keiranmraine:feature/addCython
kezhenxu94 merged 3 commits intoapache:mainfrom
keiranmraine:feature/addCython
Conversation
…sorry whitespace trimming occurred)
4 tasks
kezhenxu94
approved these changes
Aug 25, 2021
Member
kezhenxu94
left a comment
There was a problem hiding this comment.
Thank you @keiranmraine very much 🙇🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #7552
Modified:
assets/languages.yamlcomment_style_idto cython sectionREADME.mdlanguages.yamlinstead ofstyles.yamlAdded test files for
*/pyx:Confirmed working via local docker build and testing against file indicated in apache/skywalking#7552