Merged
Conversation
Member
Thanks for the feedback, where are you going to use SkyWalking-eye tool? |
Contributor
Author
Yes, i will. And i am a student participating Summer 2021 of Open Source Promotion Plan. |
kezhenxu94
approved these changes
Jul 8, 2021
Member
kezhenxu94
left a comment
There was a problem hiding this comment.
Thank you @MoGuGuai-hzr very much 🙇🏻 nice catches!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading an file named
""will raise theIsNotExisterror, so the conditional statement is unnecessary inpkg/config/config.goThe result should match whether the pattern is
.or./.Small improvement.