Remove "portions copyright" header normalizer#166
Merged
kezhenxu94 merged 1 commit intoapache:mainfrom Aug 16, 2023
antgamdia:11218-remove-copyright-regex
Merged
Remove "portions copyright" header normalizer#166kezhenxu94 merged 1 commit intoapache:mainfrom antgamdia:11218-remove-copyright-regex
kezhenxu94 merged 1 commit intoapache:mainfrom
antgamdia:11218-remove-copyright-regex
Conversation
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Member
|
I'll cancel the 0.5.0 and re-initiate the release with this patch in |
kezhenxu94
approved these changes
Aug 16, 2023
Member
@kezhenxu94 I noticed 0.5.0 tag still exists for cancelled release. Would you replace it with the latest commit and initial a new release? |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on the changes performed at #142, this PR is removing another regex that is causing the whole copyright line to be removed by the normalizer (due to the
.+$match) if the line containsPortions Copyright.closes apache/skywalking#11218
cc @kezhenxu94