Use Google's licensecheck to identify licenses#107
Conversation
|
When execute Then I explored their repositories and found that they add their licenses recently, but the versions that we depend on do not have valid licenses. So do we need add their current licenses or not? @kezhenxu94 |
Can we try to upgrade to the newer versions that have licenses? That would be more safe |
Since we depend on them indirectly, I executed |
@fgksgf I just wanted to suggest you to add the following config into dependency:
files: #...
licenses:
- name: github.com/chzyer/logex
version: v1.1.10
license: MIT |
|
For this kind of old dependencies, we need the |
kezhenxu94
left a comment
There was a problem hiding this comment.
This solution is much more neat than before and we don't have to maintain the ugly rules... Thanks for doing this @fgksgf just some nits that you might want to improve
|
Good catch, I will handle this at the weekend. @kezhenxu94 |
dep resolve(dogfooding)