Skip to content

[Eyes] Absolute path resolution bug in git ignore and check escape #7543

@wu-sheng

Description

@wu-sheng
  1. The paths-ignore are the path list that will be ignored by license-eye. By default, .git and the content in .gitignore will be inflated into the paths-ignore list.

I found this at doc, https://github.com/apache/skywalking-eyes#configurations.

So, according to doc, this is a bug.

But I would be very surprised about this folder includes actually managed files. @spacewander I think this feature was designed to skip local(never submitted files).


@kezhenxu94 @fgksgf I would treat APISIX's use case as a very specific leak case for header check. It is better to provide a local-mode(or any better name) to accept git ignore file.

Once you have a resolution, you could create a bug/feature issue with good explanations about how we should fix this. Or we could continue the discussion here.

Originally posted by @wu-sheng in #7542 (reply in thread)

Metadata

Metadata

Labels

bugSomething isn't working and you are sure it's a bug!featureNew featurelicense eye

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions