Adds setPrincipalSuffix() to AbstractLdapRealm & updates ActiveDirectoryRealm#2310
Adds setPrincipalSuffix() to AbstractLdapRealm & updates ActiveDirectoryRealm#2310fpapon merged 1 commit intoapache:mainfrom
Conversation
|
@tbrugz thank you for your contribution! Is it possible for you to add a test for this issue? |
|
@fpapon It looks like the modified code is already covered by existing test. |
bmarwell
left a comment
There was a problem hiding this comment.
I haven't touched this code in a while. It looks as if an oversight was fixed (suffix for the login username ONLY if it was not given by the user), but I cannot say much more about this.
I am not sure how this could or could not break things. I might have done something similar in my apps, but this seems safe enough. I'd say give it a try.
|
@fpapon, I've added a new test to check I've based the test on https://shiro.apache.org/testing.html (class Should I merge with this (PR) branch? |
|
@tbrugz thank you! |
Fixes #2308
By creating a new branch and resetting the old one (main), I've unintentionally closed the old PR (#2309)
Thanks for the suggestions, @lprimak !