Skip to content

Fix deprecation warnings#1630

Merged
lprimak merged 1 commit intoapache:3.xfrom
lprimak:fix-deprecation-warnings
Aug 6, 2024
Merged

Fix deprecation warnings#1630
lprimak merged 1 commit intoapache:3.xfrom
lprimak:fix-deprecation-warnings

Conversation

@lprimak
Copy link
Copy Markdown
Contributor

@lprimak lprimak commented Aug 5, 2024

Continuation of #1582
Fixes warnings and missed items discovered by replacing
SimplePrincipalCollection with ImmutablePrincipalCollection inside core

TODO:

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GitHub issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [#XXX] - Fixes bug in SessionManager,
    where you replace #XXX with the appropriate GitHub issue. Best practice
    is to use the GitHub issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • add fixes #XXX if merging the PR should close a related issue.
  • Run mvn verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Committers: Make sure a milestone is set on the PR

Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like [DOC] - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@lprimak lprimak changed the base branch from main to 3.x August 5, 2024 04:25
@lprimak lprimak self-assigned this Aug 5, 2024
@lprimak lprimak added java Pull requests that update Java code core Core Modules 3.x labels Aug 5, 2024
@lprimak lprimak modified the milestones: 2.0.2, 3.0.0 Aug 5, 2024
@lprimak lprimak requested a review from bmarwell August 6, 2024 02:27
@lprimak lprimak force-pushed the fix-deprecation-warnings branch from 3e93dc8 to f19e6c4 Compare August 6, 2024 17:56
@lprimak lprimak marked this pull request as ready for review August 6, 2024 17:57
@lprimak lprimak merged commit c6ef81a into apache:3.x Aug 6, 2024
@lprimak lprimak deleted the fix-deprecation-warnings branch August 6, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x core Core Modules java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant