Refactor/assert j best practices#1450
Closed
lprimak wants to merge 8 commits intoapache:mainfrom
timtebeek:refactor/assert-j-best-practices
Closed
Refactor/assert j best practices#1450lprimak wants to merge 8 commits intoapache:mainfrom timtebeek:refactor/assert-j-best-practices
lprimak wants to merge 8 commits intoapache:mainfrom
timtebeek:refactor/assert-j-best-practices
Conversation
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.java.testing.assertj.Assertj?organizationId=ZTU2NjRkN2YtNmViNS00MWNjLWI5OTUtNTU2YzRhOTQyMzY3 Co-authored-by: Moderne <team@moderne.io>
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.java.testing.assertj.Assertj?organizationId=YzQ4NzM2ZmItNmRjOS00ZmU2LWJhOTUtNDQ4NTViYTRhNWFk Co-authored-by: Moderne <team@moderne.io>
timtebeek
reviewed
May 2, 2024
| import org.apache.shiro.authc.UsernamePasswordToken; | ||
|
|
||
| import static org.apache.shiro.ee.util.JakartaTransformer.jakartify; | ||
| import static org.assertj.core.api.Assertions.assertThat; |
Contributor
There was a problem hiding this comment.
This seems to have brought on an error in the tests, despite there being a transitive assertj dependency.
[INFO] Running org.apache.shiro.testing.cdi.ComponentInjectionIT
Error: Tests run: 4, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 16.51 s <<< FAILURE! -- in org.apache.shiro.testing.cdi.ComponentInjectionIT
Error: org.apache.shiro.testing.cdi.ComponentInjectionIT.principalInjection -- Time elapsed: 0.407 s <<< ERROR!
java.lang.NoClassDefFoundError: org/assertj/core/api/Assertions
at org.apache.shiro.testing.cdi.ComponentInjectionIT.principalInjection(ComponentInjectionIT.java:107)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at org.jboss.arquillian.junit5.ArquillianExtension.interceptTestMethod(ArquillianExtension.java:87)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
Caused by: java.lang.ClassNotFoundException: org.assertj.core.api.Assertions
at org.glassfish.web.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1821)
at org.glassfish.web.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1662)
... 5 more
How would we want to see this resolved?
Contributor
Author
There was a problem hiding this comment.
Probably Arquillian deployment method needs to be updated with AssertJ classes
bmarwell
approved these changes
May 2, 2024
Contributor
bmarwell
left a comment
There was a problem hiding this comment.
I have done similar migrations in the past with similar-sized projects. You have my go when all the tests work. I did peek into ~30 files and saw no changes I would not approve.
10 tasks
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following this checklist to help us incorporate your contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
[#XXX] - Fixes bug in SessionManager,where you replace
#XXXwith the appropriate GitHub issue. Best practiceis to use the GitHub issue title in the pull request title and in the first line of the commit message.
fixes #XXXif merging the PR should close a related issue.mvn verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.git rebase -i.Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like
[DOC] - Add javadoc in SessionManager.If this is your first contribution, you have to read the Contribution Guidelines
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.