Change the execution phase of NativeTest under GraalVM Native Image from test to integration-test#36050
Merged
Merged
Conversation
e741a8a to
5d4d201
Compare
…rom `test` to `integration-test`
yx9o
approved these changes
Jul 22, 2025
This was referenced Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #29052 .
Changes proposed in this pull request:
testtointegration-test. This is a review of Fix the bug that nativeTest test suite cannot recognize modules without source code #35959 and Add support for running integration tests with Maven graalvm/native-build-tools#740 .nativeTestInShardingSpherechanged the binding phase ofmaven-jar-plugin:jarfrompackagetotest, which broke some conventions of the Maven lifecycle and caused the third-party Maven plugin to misjudge some things. For thejargoal oforg.eclipse.transformer:transformer-maven-pluginintroduced in Add optional module for Jakarta Transactions impl of Jakarta EE 9 Spec #35810, this further caused the jar of the required sourceless module to not be successfully created in thetestphase, because thejargoal oforg.eclipse.transformer:transformer-maven-pluginagain eliminated the configuration ofmaven-jar-plugin. We can't use thetransformgoal oforg.eclipse.transformer:transformer-maven-pluginbecause we didn't actually configure whatmaven-jar-plugindoes. See Native Build Tools cannot recognize Maven modules that only havepom.xmlbut no source code graalvm/native-build-tools#727 .packagephase, then the unit tests should be executed in theintegration-testphase. This is because thetestphase occurs before thepackagephase.metadata-copyMaven goal to simplify the use of integration tests graalvm/native-build-tools#748 to simplify the additional configuration of themetadata-copygoal.Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.