Skip to content

Provide native-image.properties containing --report-unsupported-elements-at-runtime of buildArgs#29124

Merged
terrymanu merged 1 commit into
apache:masterfrom
linghengqian:fix-graalvm-buildargs
Nov 23, 2023
Merged

Provide native-image.properties containing --report-unsupported-elements-at-runtime of buildArgs#29124
terrymanu merged 1 commit into
apache:masterfrom
linghengqian:fix-graalvm-buildargs

Conversation

@linghengqian

@linghengqian linghengqian commented Nov 22, 2023

Copy link
Copy Markdown
Member

For #29052.

Changes proposed in this pull request:

java.io.IOException: Stream closed
	at java.base@17.0.9/java.io.BufferedInputStream.getInIfOpen(BufferedInputStream.java:157)
	at java.base@17.0.9/java.io.BufferedInputStream.fill(BufferedInputStream.java:244)
	at java.base@17.0.9/java.io.BufferedInputStream.read(BufferedInputStream.java:263)
	at java.base@17.0.9/java.io.DataInputStream.readUnsignedShort(DataInputStream.java:334)
	at java.base@17.0.9/java.io.DataInputStream.readUTF(DataInputStream.java:583)
	at java.base@17.0.9/java.io.DataInputStream.readUTF(DataInputStream.java:558)
	at org.codehaus.groovy.reflection.GeneratedMetaMethod$DgmMethodRecord.loadDgmInfo(GeneratedMetaMethod.java:200)

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@linghengqian linghengqian marked this pull request as ready for review November 22, 2023 08:35

@linghengqian linghengqian left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We can of course reject the built-in native-image.properties since this is not a generic GraalVM Reachability Metadata, but there is no way we can use the graalvm feature classes. Waiting for review.

@terrymanu terrymanu added this to the 5.4.2 milestone Nov 23, 2023
@terrymanu terrymanu merged commit 3aff42f into apache:master Nov 23, 2023
@linghengqian linghengqian deleted the fix-graalvm-buildargs branch November 23, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants