Provide native-image.properties containing --report-unsupported-elements-at-runtime of buildArgs#29124
Merged
Merged
Conversation
59d8a0d to
949b638
Compare
…ements-at-runtime` of buildArgs
949b638 to
511ce5d
Compare
linghengqian
commented
Nov 22, 2023
linghengqian
left a comment
Member
Author
There was a problem hiding this comment.
- We can of course reject the built-in
native-image.propertiessince this is not a generic GraalVM Reachability Metadata, but there is no way we can use the graalvm feature classes. Waiting for review.
terrymanu
approved these changes
Nov 23, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #29052.
Changes proposed in this pull request:
native-image.propertiescontaining--report-unsupported-elements-at-runtimeof buildArgs. Since the behavior of classes likegroovy.lang.Closurecannot be described by GraalVM Reachability Metadata V1.0.0, I expect to build the buildArgs directly intoorg.apache.shardingsphere:shardingsphere-infra-reachability-metadatauntil I find a better solution. Reference https://www.graalvm.org/docs/reference-manual/native-image/assets/reflect-config-schema-v1.0.0.json .generateMetadata.InlineExpressionParserFactory's parsing of Groovy syntax by default under GraalVM Native Image.shardingsphere-cluster-mode-repository-etcdno longer prevents compilation of ShardingSphere Proxy Native.META-INF/dgminfointo Groovy’s GraalVM Reachability Metadata to avoid a Log. Refer to https://github.com/apache/shardingsphere/actions/runs/6947807930/job/18902440695 .java.io.IOException: Stream closed at java.base@17.0.9/java.io.BufferedInputStream.getInIfOpen(BufferedInputStream.java:157) at java.base@17.0.9/java.io.BufferedInputStream.fill(BufferedInputStream.java:244) at java.base@17.0.9/java.io.BufferedInputStream.read(BufferedInputStream.java:263) at java.base@17.0.9/java.io.DataInputStream.readUnsignedShort(DataInputStream.java:334) at java.base@17.0.9/java.io.DataInputStream.readUTF(DataInputStream.java:583) at java.base@17.0.9/java.io.DataInputStream.readUTF(DataInputStream.java:558) at org.codehaus.groovy.reflection.GeneratedMetaMethod$DgmMethodRecord.loadDgmInfo(GeneratedMetaMethod.java:200)Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.