Open the resource:/ related FileSystem for JDBCRepositorySQLLoader in the GraalVM Native Image environment#29009
Merged
Conversation
7 tasks
…in the GraalVM Native Image environment
04ca562 to
49e87ce
Compare
linghengqian
commented
Nov 11, 2023
linghengqian
left a comment
Member
Author
There was a problem hiding this comment.
- Naturally, we can continue to keep similar operations within specific unit tests, because the current behavior is actually consistent with the behavior in Jar. Calling resource URI inside Jar also requires opening FileSystem. I'm still looking for a review.
terrymanu
approved these changes
Nov 11, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #29000.
Changes proposed in this pull request:
resource:/related FileSystem for JDBCRepositorySQLLoader in the GraalVM Native Image environment.NativeImageResourceFileSystemProvider, the correspondingNativeImageResourceFileSystemdoes not autoload. This is mainly to align the behavior ofZipFileSystemProvider, so we need to manually open and close the FileSystem corresponding to theresource:/scheme. For more background reference Cannot open native image resource using Path, NativeImageResourceFileSystemProvider not initialised oracle/graal#7682 .org.graalvm.nativeimage.imagecodeto identify whether this class is in the GraalVM Native Image environment. The background of this property comes from Annotation Interface DisabledInNativeImage on Junit.Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.