Refactor shardingsphere-infra-expr to expose the use of Row Value Expressions SPI#28340
Merged
Conversation
5e19929 to
3de6da6
Compare
shardingsphere-infra-expr to expose the use of SPIshardingsphere-infra-expr to expose the use of Row Value Expressions SPI
750d135 to
12c24e4
Compare
12c24e4 to
793caea
Compare
6 tasks
terrymanu
approved these changes
Sep 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #22899.
Changes proposed in this pull request:
shardingsphere-infra-exprto expose the use of Row Value Expressions SPI. Introduced the use of SPI for<SPITypeName>dataNodes. A simple implementation of this SPI is located atCustomInlineExpressionParserFixture. Unit tests are located atInlineExpressionParserFactoryTest.shardingsphere-infra-expr-hotsoptmodule was renamedshardingsphere-infra-expr-groovy, and the Type Name of the corresponding SPI implementation was changed fromHOTSPOTtoGROOVY.InlineExpressionParserinterface, the input parameters of all functions are processed in advance toInlineExpressionParserFactory#newInstance. The existence ofhandlePlaceHolder()andevaluateClosure()is as diluted as possible, and users should only implement thesplitAndEvaluate()method and a fixed-contenthandlePlaceHolder()method in most cases.evaluateClosure()should be extracted to some different classes, as it is foreseeable that in most cases the SPI implementation will not use Groovy's class.Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.