Migrate from Jakarta EE 8 to Jakarta EE 9 by linghengqian · Pull Request #27976 · apache/shardingsphere

linghengqian · 2023-08-07T12:32:34Z

Fixes #26041.

Changes proposed in this pull request:

Migrate from Jakarta EE 8 to Jakarta EE 9. Refer to https://jakarta.ee/release/9/ .
- Migrate jakarta.platform:jakarta.jakartaee-bom:8.0.0 to jakarta.platform:jakarta.jakartaee-bom:9.0.0.
- Migrate org.glassfish.jaxb:jaxb-bom:2.3.9 to org.glassfish.jaxb:jaxb-bom:3.0.2.
- Since Jakarta EE 9.1, the baseline JDK version was upgraded to JDK 11, and features after that were not available on the ShardingSphere side.
- javax.transaction.xa.* was retained because javax.transaction.xa.* is now part of Java SE 21. Refer to https://jakarta.ee/specifications/transactions/2.0/jakarta-transactions-spec-2.0.html#java-se .
- This change means that all Java EE 8-based web frameworks cannot use ShardingSphere's XA distributed transactions. As a reminder, Spring Boot OSS 2.7.x, the last version of Spring Boot OSS to use Java EE 8, will end community support on 2023-11-18. Refer to https://spring.io/projects/spring-boot#support .
Replace the jakarta variant with Narayana 5.12.7.Final.
- Since Narayana 5.13.0.Final, the baseline JDK version was upgraded to JDK 11, and features after that were not available on the ShardingSphere side. Refer to https://issues.redhat.com/browse/JBTM-3590 .
- At the Narayana 5.12.4.Final milestone, the JBoss Team created Jakarta variants for Uber Jars like org.jboss.narayana.jta:narayana-jta, such as org.jboss.narayana.jta:narayana-jta-jakarta, but not for org.jboss.narayana.jta:jta, so the ShardingSphere side needs to use Narayana's Uber Jar. Reference https://issues.redhat.com/secure/ReleaseNote.jspa?projectId=12310200&version=12378489 and https://github.com/jbosstm/narayana/blob/5.12.7.Final/ArjunaJTA/narayana-jta-jakarta/pom.xml .
- More early discussions are in https://issues.redhat.com/browse/JBTM-3544 .
- Once ShardingSphere upgrades the baseline JDK version to JDK 11 in the future, we can update Narayana to 7.0.0.Final.
Update jboss-logging to 3.4.3.Final. This is just to avoid the CVE passed over by Narayana.
- Since org.jboss.logging:jboss-logging:3.5.0.Final, the baseline JDK version was upgraded to JDK 11, and features after that were not available on the ShardingSphere side. Refer to https://issues.redhat.com/browse/JBLOGGING-162 .
Replace the jakarta variant with Atomikos 6.0.0. The jakarta variant of Atomikos does not have a bom, so this PR removes the corresponding bom.

Before committing this PR, I'm sure that I have checked the following options:

My code follows the code of conduct of this project.
I have self-reviewed the commit code.
I have (or in comment I request) added corresponding labels for the pull request.
I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
I have made corresponding changes to the documentation.
I have added corresponding unit tests for my changes.

terrymanu · 2023-08-12T09:25:43Z

Thank you, I need more time to check it.

linghengqian

This PR will be converted to a draft. I'm still not sure if this PR should be merged before Spring Boot OSS 2.x reaches end of OSS support, unless the original issue gets broader feedback.

github-actions · 2023-09-11T20:05:07Z

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.

linghengqian

@terrymanu Since web frameworks like Quarkus have started to actively exclude older Java EE 8 dependencies, can we merge this PR at the current milestone? See #26041 (comment) .
Spring boot 2.x will stop OSS support on 2023/11/24, and the next release of shardingsphere will be next month.

totalo

LGTM

linghengqian

So for this current controversial PR, I assume there are two steps that need to be taken care of first - this will align with what Narayana was doing during the transition period.

Migrate from Java EE 8 to Jakarta EE 8. This will only change the GAV information of the corresponding dependencies to align the behavior of Spring Boot 2.2-2.7.
Create a Jakarta EE 9 variant of ShardingSphere JDBC Core. The series of processing of ShardingSphere at DistSQL is ignored for the time being, because DistSQL only involves ShardingSphere Proxy.

linghengqian · 2024-05-16T10:59:51Z

This PR will not actually prevent Spring Boot OSS 3 integration, as usage of the JAXB API has been removed in Removes use of JAXB API via jackson-dataformat-xml #29384.

Of course, XA distributed transactions are still not ready on Spring Boot OSS 3/Quarkus 3/Micronaut Framework 4/Helidon 3/Helidon 4. Since the SPI and corresponding implementation of XA distributed transactions has always been an optional module, creating a Jakarta EE variant for an optional module seems very strange and far inferior to the current PR solution.

If When the localName property of @JacksonXmlProperty is not set, the required of @JsonProperty does not detect the property name of POJO FasterXML/jackson-dataformat-xml#628 is resolved, I will try to remove the use of JAXB API in the test suite. This will further reduce the impact of this PR.

Terminate this process until further exploration is conducted in shardingsphere-jdbc-5.5.0 causes spring boot to return JSON data as XML #31203 within the context of Spring Boot's WebMVC component. It appears, based on the issue description, that regardless of the XML parsing library introduced, there always exists a corresponding auto-configuration within Spring Boot's WebMVC component that modifies the format of responses from the controller layer. However, the associated issue still lacks unit tests.

linghengqian

If FasterXML/jackson-dataformat-xml#628 is resolved, I will try to remove the use of JAXB API in the test suite. This will further reduce the impact of this PR.

It's hard to say there's an easy way to ensure that XML parsing libraries from Jakarta EE 8's Java API are converted to Jackson XML's Java API. This is compounded by the breaking changes in Jackson 3.0, and the situation becomes even more confusing. I'm going to close the current PR and wait for the future release of Jackson 3.0.
Also see https://github.com/FasterXML/jackson/wiki/Jackson-Release-3.0 and spring-projects/spring-framework#33798 .

Java 17 is now required for all components, except for jackson-annotations that still requires just Java 8

linghengqian added the type: dependencies Pull requests that update a dependency file label Aug 7, 2023

linghengqian force-pushed the convert-to-jakarta branch 8 times, most recently from 32089fa to 0ebf477 Compare August 7, 2023 21:19

linghengqian marked this pull request as ready for review August 7, 2023 22:04

linghengqian mentioned this pull request Aug 7, 2023

Transition from Jakarta EE 8 to Jakarta EE 9 #26041

Open

linghengqian force-pushed the convert-to-jakarta branch 4 times, most recently from 54cd961 to 38f7e10 Compare August 10, 2023 16:44

linghengqian commented Aug 12, 2023

View reviewed changes

linghengqian marked this pull request as draft August 12, 2023 11:25

github-actions Bot added the stale label Sep 11, 2023

linghengqian force-pushed the convert-to-jakarta branch from 38f7e10 to 45b1c32 Compare September 12, 2023 03:05

linghengqian removed the stale label Sep 12, 2023

linghengqian force-pushed the convert-to-jakarta branch from 45b1c32 to 6e85b0e Compare November 19, 2023 16:32

linghengqian marked this pull request as ready for review November 19, 2023 16:45

linghengqian commented Nov 19, 2023

View reviewed changes

totalo previously approved these changes Nov 21, 2023

View reviewed changes

linghengqian dismissed totalo’s stale review via 949565f November 24, 2023 12:40

linghengqian force-pushed the convert-to-jakarta branch from 6e85b0e to 949565f Compare November 24, 2023 12:40

linghengqian marked this pull request as draft November 24, 2023 16:56

linghengqian commented Nov 25, 2023

View reviewed changes

linghengqian force-pushed the convert-to-jakarta branch 3 times, most recently from 4edd5df to 1cc879b Compare February 11, 2024 15:54

linghengqian force-pushed the convert-to-jakarta branch 3 times, most recently from b6d5e78 to 6ae79a4 Compare February 24, 2024 14:28

linghengqian mentioned this pull request Mar 1, 2024

Bump pgjbdc version to prevent CVE from being passed in Proxy #30369

Merged

6 tasks

linghengqian force-pushed the convert-to-jakarta branch from 6ae79a4 to 23edfec Compare March 3, 2024 14:43

linghengqian added the feature: transaction label Mar 3, 2024

linghengqian force-pushed the convert-to-jakarta branch from 23edfec to c397c91 Compare April 5, 2024 00:41

linghengqian force-pushed the convert-to-jakarta branch from c397c91 to f26ed3a Compare July 7, 2024 05:41

linghengqian force-pushed the convert-to-jakarta branch 2 times, most recently from 3acf25b to 4e240e8 Compare July 22, 2024 15:49

linghengqian force-pushed the convert-to-jakarta branch from 4e240e8 to 0330b30 Compare August 1, 2024 08:20

linghengqian force-pushed the convert-to-jakarta branch from 0330b30 to 7b31dbf Compare August 16, 2024 04:46

linghengqian force-pushed the convert-to-jakarta branch from 7b31dbf to 728b10d Compare September 19, 2024 07:38

linghengqian force-pushed the convert-to-jakarta branch from 728b10d to 227dc57 Compare October 14, 2024 05:42

linghengqian mentioned this pull request Oct 26, 2024

Bump org.springframework:spring-context from 5.2.22.RELEASE to 6.1.14 in /examples #33312

Closed

linghengqian force-pushed the convert-to-jakarta branch from 227dc57 to cd1496d Compare November 1, 2024 18:08

linghengqian mentioned this pull request Nov 15, 2024

springboot3.3.1 config XA Narayana exception #33675

Closed

linghengqian mentioned this pull request Nov 28, 2024

shardingsphere jdbc failed in XA mode #33834

Closed

linghengqian force-pushed the convert-to-jakarta branch from cd1496d to db29a09 Compare December 8, 2024 12:49

linghengqian mentioned this pull request Jan 20, 2025

Upgraded third-party dependencies to the latest versions and fixed CVE vulnerabilities #34409

Closed

7 tasks

Migrate from Jakarta EE 8 to Jakarta EE 9

374bbd4

linghengqian force-pushed the convert-to-jakarta branch from db29a09 to 374bbd4 Compare January 25, 2025 08:39

linghengqian commented Jan 26, 2025

View reviewed changes

linghengqian closed this Jan 26, 2025

linghengqian deleted the convert-to-jakarta branch January 26, 2025 07:19

linghengqian mentioned this pull request Jun 26, 2025

Add optional module for Jakarta Transactions impl of Jakarta EE 9 Spec #35810

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate from Jakarta EE 8 to Jakarta EE 9#27976

Migrate from Jakarta EE 8 to Jakarta EE 9#27976
linghengqian wants to merge 1 commit into
apache:masterfrom
linghengqian:convert-to-jakarta

linghengqian commented Aug 7, 2023 •

edited

Loading

Uh oh!

terrymanu commented Aug 12, 2023

Uh oh!

linghengqian left a comment

Uh oh!

github-actions Bot commented Sep 11, 2023

Uh oh!

linghengqian left a comment

Uh oh!

totalo left a comment

Uh oh!

linghengqian left a comment

Uh oh!

linghengqian commented May 16, 2024

Uh oh!

linghengqian left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

linghengqian commented Aug 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

terrymanu commented Aug 12, 2023

Uh oh!

linghengqian left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 11, 2023

Uh oh!

linghengqian left a comment

Choose a reason for hiding this comment

Uh oh!

totalo left a comment

Choose a reason for hiding this comment

Uh oh!

linghengqian left a comment

Choose a reason for hiding this comment

Uh oh!

linghengqian commented May 16, 2024

Uh oh!

linghengqian left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

linghengqian commented Aug 7, 2023 •

edited

Loading