Skip to content

Initialize the generateStandardMetadata Maven Profile of all module#24271

Merged
terrymanu merged 1 commit into
apache:masterfrom
linghengqian:graalvm-trace-metadata
Apr 16, 2023
Merged

Initialize the generateStandardMetadata Maven Profile of all module#24271
terrymanu merged 1 commit into
apache:masterfrom
linghengqian:graalvm-trace-metadata

Conversation

@linghengqian

@linghengqian linghengqian commented Feb 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

For #21347.

Changes proposed in this pull request:

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@linghengqian linghengqian force-pushed the graalvm-trace-metadata branch from 1cadfce to 02b88b8 Compare February 21, 2023 06:51
@linghengqian

linghengqian commented Feb 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author
  • I personally don't want to bring the artifacts of this task into the main branch at this stage, because each submodule will generate 6 files, and we will end up needing to maintain 546 JSON files of GraalVM reachability metadata.
  • image

@linghengqian linghengqian mentioned this pull request Feb 21, 2023
Closed
7 tasks
@linghengqian linghengqian marked this pull request as ready for review February 21, 2023 07:16
@codecov-commenter

codecov-commenter commented Feb 21, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #24271 (c89aebe) into master (c42e1a3) will not change coverage.
The diff coverage is n/a.

❗ Current head c89aebe differs from pull request most recent head 9a08d59. Consider uploading reports for the commit 9a08d59 to get more accurate results

@@            Coverage Diff            @@
##             master   #24271   +/-   ##
=========================================
  Coverage     49.97%   49.97%           
  Complexity     1573     1573           
=========================================
  Files          3253     3253           
  Lines         53440    53440           
  Branches       9854     9854           
=========================================
  Hits          26706    26706           
  Misses        24365    24365           
  Partials       2369     2369

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@linghengqian linghengqian force-pushed the graalvm-trace-metadata branch 7 times, most recently from d538bbb to eabaf18 Compare February 21, 2023 11:18
@linghengqian linghengqian marked this pull request as draft February 21, 2023 11:29
@linghengqian linghengqian force-pushed the graalvm-trace-metadata branch 14 times, most recently from eeafc99 to 80a85ef Compare February 24, 2023 15:26
@linghengqian linghengqian changed the title Initialize the collectReachabilityMetadata Maven Task of all module Initialize the generateStandardMetadata Maven Profile of all module Feb 25, 2023
@linghengqian linghengqian force-pushed the graalvm-trace-metadata branch 2 times, most recently from ab462da to 7682678 Compare February 25, 2023 07:41
@linghengqian linghengqian force-pushed the graalvm-trace-metadata branch 4 times, most recently from 991697c to e058cf0 Compare April 3, 2023 19:48
@linghengqian linghengqian force-pushed the graalvm-trace-metadata branch from e058cf0 to 2d50723 Compare April 4, 2023 02:48
@linghengqian linghengqian marked this pull request as ready for review April 4, 2023 04:32
@linghengqian linghengqian force-pushed the graalvm-trace-metadata branch 4 times, most recently from fb35837 to d892a7e Compare April 6, 2023 08:27
linghengqian
linghengqian commented Apr 6, 2023
View reviewed changes

@linghengqian linghengqian left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@linghengqian linghengqian force-pushed the graalvm-trace-metadata branch 2 times, most recently from 9f9127c to 887a779 Compare April 8, 2023 14:08
@linghengqian linghengqian force-pushed the graalvm-trace-metadata branch 2 times, most recently from fea2aff to 02289cd Compare April 15, 2023 15:23
@linghengqian linghengqian force-pushed the graalvm-trace-metadata branch from 02289cd to 1650d98 Compare April 15, 2023 15:35
@terrymanu terrymanu added this to the 5.3.3 milestone Apr 16, 2023
@terrymanu terrymanu merged commit e2e883f into apache:master Apr 16, 2023
@linghengqian linghengqian deleted the graalvm-trace-metadata branch April 16, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terrymanu terrymanu terrymanu approved these changes

@zhaojinchao95 zhaojinchao95 Awaiting requested review from zhaojinchao95

Assignees

No one assigned

Labels

type: build

Projects

None yet

Milestone

5.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@linghengqian @codecov-commenter @terrymanu