Introduce Truffle Espresso to make GroovyShell available under GraalVM Native Image#23873
Merged
Merged
Conversation
dd6d1c5 to
7863dd5
Compare
7 tasks
3181ba4 to
7783545
Compare
linghengqian
commented
Jan 31, 2023
Comment on lines
+52
to
+63
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-dependency-plugin</artifactId> | ||
| <executions> | ||
| <execution> | ||
| <id>copy</id> | ||
| <goals> | ||
| <goal>copy</goal> | ||
| </goals> | ||
| <phase>package</phase> |
Member
Author
There was a problem hiding this comment.
-
Logically, we need to advance the Maven life cycle that executes
copytoprocess-test-classes, so that we can verify the unit tests of Truffle Espresso in the future nativeTest. -
But I'm not sure how to make
org.apache.shardingsphere:shardingsphere-infra-util-groovy:${project.version}advance./mvnw clean installso that the task ofcopygets the corresponding JAR. -
Is there any way for Maven to solve this kind of problem without stepping in the CI file?
Member
Author
There was a problem hiding this comment.
- If the answer to this question is no, considering that the classes that really need to be executed on the Espresso VM are no different on 5.3.1 and 5.3.2, I can use
shardingsphere infra-util:5.3.1to provide the classpath required for espresso.
linghengqian
commented
Jan 31, 2023
Comment on lines
+38
to
+55
| static { | ||
| // https://github.com/oracle/graal/issues/4555 not yet closed | ||
| String javaHome = System.getenv("GRAALVM_HOME"); | ||
| if (javaHome == null) { | ||
| javaHome = System.getenv("JAVA_HOME"); | ||
| } | ||
| if (javaHome == null) { | ||
| throw new RuntimeException("Failed to determine the system's environment variable GRAALVM_HOME or JAVA_HOME!"); | ||
| } | ||
| System.setProperty("org.graalvm.home", javaHome); | ||
| URL resource = Thread.currentThread().getContextClassLoader().getResource("espresso-need-libs"); | ||
| assert null != resource; | ||
| String dir = resource.getPath(); | ||
| String javaClasspath = String.join(":", dir + "/groovy.jar", dir + "/guava.jar", dir + "/shardingsphere-infra-util-groovy.jar"); | ||
| POLYGLOT = Context.newBuilder().allowAllAccess(true) | ||
| .option("java.MultiThreaded", "true") | ||
| .option("java.Classpath", javaClasspath) | ||
| .build(); | ||
| } |
Member
Author
There was a problem hiding this comment.
-
This class is difficult to set up tests because Espresso is not available outside of GraalVM, it is not standalone like other Truffle implementations.
-
But if necessary, I can add a CI to complete the test under GraalVM CE.
7783545 to
7ee3e88
Compare
linghengqian
commented
Jan 31, 2023
Comment on lines
+63
to
74
| <phase>process-test-classes</phase> | ||
| <configuration> | ||
| <artifactItems> | ||
| <artifactItem> | ||
| <groupId>org.apache.shardingsphere</groupId> | ||
| <artifactId>shardingsphere-infra-util-groovy</artifactId> | ||
| <version>${project.version}</version> | ||
| <artifactId>shardingsphere-infra-util</artifactId> | ||
| <version>5.3.1</version> | ||
| <type>jar</type> | ||
| <overWrite>true</overWrite> | ||
| <destFileName>shardingsphere-infra-util-groovy.jar</destFileName> | ||
| <destFileName>shardingsphere-infra-util.jar</destFileName> | ||
| </artifactItem> |
Member
Author
There was a problem hiding this comment.
- This is another processing idea that I pointed out at Introduce Truffle Espresso to make GroovyShell available under GraalVM Native Image #23873 (comment) .
7ee3e88 to
8b60d3b
Compare
linghengqian
commented
Jan 31, 2023
Codecov Report
@@ Coverage Diff @@
## master #23873 +/- ##
============================================
- Coverage 50.19% 50.16% -0.03%
Complexity 1567 1567
============================================
Files 3247 3249 +2
Lines 53483 53534 +51
Branches 9800 9812 +12
============================================
+ Hits 26844 26857 +13
- Misses 24280 24312 +32
- Partials 2359 2365 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
8b60d3b to
9af249c
Compare
linghengqian
commented
Jan 31, 2023
linghengqian
left a comment
Member
Author
There was a problem hiding this comment.
- I checked https://github.com/apache/shardingsphere/actions/runs/4054863246/jobs/6977753161 and the CI timeout seems to be caused by other PRs.
1ec235c to
8492c7e
Compare
892a612 to
106668d
Compare
…M Native Image and update GraalVM Reachability Metadata Repository to 0.2.6
106668d to
d7b0e8e
Compare
terrymanu
approved these changes
Feb 2, 2023
This was referenced Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #21347 and #22899.
Changes proposed in this pull request:
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.