Skip to content

Add support for java.sql.Date in IntervalShardingAlgorithm#22495

Merged
terrymanu merged 1 commit into
apache:masterfrom
linghengqian:fix-date
Dec 2, 2022
Merged

Add support for java.sql.Date in IntervalShardingAlgorithm#22495
terrymanu merged 1 commit into
apache:masterfrom
linghengqian:fix-date

Conversation

@linghengqian

@linghengqian linghengqian commented Nov 29, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

For #21347 (comment) .

Changes proposed in this pull request:

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@linghengqian linghengqian changed the title Add support for java.sql.Date for IntervalShardingAlgorithm Add support for java.sql.Date in IntervalShardingAlgorithm Nov 29, 2022
@linghengqian linghengqian mentioned this pull request Nov 29, 2022
Closed
7 tasks
@codecov-commenter

codecov-commenter commented Nov 29, 2022

Copy link
Copy Markdown

Codecov Report

Merging #22495 (e9aed54) into master (07300fd) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master   #22495      +/-   ##
============================================
- Coverage     50.99%   50.98%   -0.02%     
  Complexity     2514     2514              
============================================
  Files          4185     4185              
  Lines         58232    58241       +9     
  Branches       9898     9903       +5     
============================================
- Hits          29695    29693       -2     
- Misses        26011    26018       +7     
- Partials       2526     2530       +4
Impacted Files Coverage Δ
...hority/yaml/config/YamlAuthorityConfiguration.java 0.00% <ø> (ø)
...aml/config/YamlSQLTranslatorRuleConfiguration.java 0.00% <0.00%> (ø)
...kend/config/yaml/YamlProxyServerConfiguration.java 55.55% <ø> (ø)
...proxy/backend/config/ProxyConfigurationLoader.java 60.00% <30.76%> (-12.10%) ⬇️
...m/sharding/datetime/IntervalShardingAlgorithm.java 79.26% <100.00%> (+0.25%) ⬆️
...ty/yaml/config/YamlAuthorityRuleConfiguration.java 66.66% <100.00%> (ø)
...er/yaml/config/YamlSQLParserRuleConfiguration.java 50.00% <100.00%> (ø)
...ffic/yaml/config/YamlTrafficRuleConfiguration.java 80.00% <100.00%> (ø)
.../yaml/config/YamlTransactionRuleConfiguration.java 50.00% <100.00%> (ø)
...handler/distsql/ral/hint/enums/HintSourceType.java 0.00% <0.00%> (-42.86%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@terrymanu terrymanu merged commit a8ab167 into apache:master Dec 2, 2022
@terrymanu terrymanu added this to the 5.3.0 milestone Dec 2, 2022
@linghengqian linghengqian deleted the fix-date branch December 2, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terrymanu terrymanu terrymanu approved these changes

Assignees

No one assigned

Labels

feature: sharding type: enhancement

Projects

None yet

Milestone

5.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@linghengqian @codecov-commenter @terrymanu