Skip to content

Build GraalVM Native Image nightly for ShardingSphere Proxy#21109

Merged
terrymanu merged 4 commits into
apache:masterfrom
linghengqian:graalvm-native-image
Oct 3, 2022
Merged

Build GraalVM Native Image nightly for ShardingSphere Proxy#21109
terrymanu merged 4 commits into
apache:masterfrom
linghengqian:graalvm-native-image

Conversation

@linghengqian

@linghengqian linghengqian commented Sep 21, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

For #21051.

Changes proposed in this pull request:

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have triggered maven check: mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@codecov-commenter

codecov-commenter commented Sep 21, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #21109 (b1e04b0) into master (e5cf12d) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #21109      +/-   ##
============================================
- Coverage     61.61%   61.61%   -0.01%     
+ Complexity     2479     2475       -4     
============================================
  Files          4061     4064       +3     
  Lines         55882    55867      -15     
  Branches       9466     9464       -2     
============================================
- Hits          34430    34420      -10     
+ Misses        18575    18571       -4     
+ Partials       2877     2876       -1
Impacted Files Coverage Δ
...saction/xa/XAShardingSphereTransactionManager.java 65.00% <0.00%> (-2.50%) ⬇️
...ardingsphere/transaction/rule/TransactionRule.java 33.33% <0.00%> (-0.63%) ⬇️
...eterized/jaxb/cases/domain/SQLParserTestCases.java 99.30% <0.00%> (-0.01%) ⬇️
...ser/core/kernel/KernelDistSQLStatementVisitor.java 0.00% <0.00%> (ø)
...eption/rule/InvalidRuleConfigurationException.java 0.00% <0.00%> (ø)
.../shardingsphere/data/pipeline/api/job/JobType.java 0.00% <0.00%> (ø)
...ation/query/QueryableScalingRALBackendHandler.java 0.00% <0.00%> (ø)
...tion/update/UpdatableScalingRALBackendHandler.java 0.00% <0.00%> (ø)
...ent/distsql/rql/impl/ShowRulesStatementAssert.java 100.00% <0.00%> (ø)
...peline/scenario/migration/MigrationJobAPIImpl.java 0.00% <0.00%> (ø)
... and 28 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

taojintianxia
taojintianxia reviewed Sep 21, 2022
View reviewed changes
Comment thread .github/workflows/native.yml Outdated
@linghengqian linghengqian force-pushed the graalvm-native-image branch 9 times, most recently from b92b338 to 8ad4592 Compare September 22, 2022 12:50
@linghengqian linghengqian force-pushed the graalvm-native-image branch 16 times, most recently from 6be27b5 to ca840e8 Compare September 23, 2022 05:52
@linghengqian linghengqian force-pushed the graalvm-native-image branch 3 times, most recently from 1a2718b to 7487d38 Compare September 28, 2022 14:21
linghengqian
linghengqian commented Sep 28, 2022
View reviewed changes
Comment thread shardingsphere-distribution/shardingsphere-proxy-distribution/pom.xml Outdated
Comment thread .github/workflows/native.yml
Comment thread .github/workflows/native.yml
Comment thread .github/workflows/native.yml
Comment thread shardingsphere-distribution/shardingsphere-proxy-distribution/pom.xml Outdated
Comment thread .github/workflows/native.yml
Comment thread docs/document/content/user-manual/shardingsphere-proxy/startup/graalvm-native-image.cn.md
Comment thread docs/document/content/user-manual/shardingsphere-proxy/startup/graalvm-native-image.cn.md
Comment thread shardingsphere-distribution/shardingsphere-proxy-distribution/pom.xml Outdated
@linghengqian linghengqian marked this pull request as ready for review September 28, 2022 14:51
linghengqian
linghengqian commented Sep 28, 2022
View reviewed changes
Comment thread .github/workflows/native.yml
linghengqian
linghengqian commented Sep 29, 2022
View reviewed changes
Comment thread shardingsphere-distribution/shardingsphere-proxy-distribution/pom.xml Outdated
@linghengqian

linghengqian commented Sep 30, 2022

Copy link
Copy Markdown
Member Author
  • Maybe a friend can give some review comments?

@linghengqian linghengqian mentioned this pull request Oct 3, 2022
Closed
terrymanu
terrymanu reviewed Oct 3, 2022
View reviewed changes

@terrymanu terrymanu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about split GraalVM to independent distribute module?

@linghengqian linghengqian force-pushed the graalvm-native-image branch 2 times, most recently from e5cef53 to fca3086 Compare October 3, 2022 07:46
@linghengqian

linghengqian commented Oct 3, 2022

Copy link
Copy Markdown
Member Author

@linghengqian linghengqian force-pushed the graalvm-native-image branch 2 times, most recently from a64e877 to ba3d623 Compare October 3, 2022 08:06
@linghengqian

linghengqian commented Oct 3, 2022

Copy link
Copy Markdown
Member Author

done.

terrymanu
terrymanu reviewed Oct 3, 2022
View reviewed changes

@terrymanu terrymanu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@terrymanu terrymanu added this to the 5.2.1 milestone Oct 3, 2022
@terrymanu terrymanu merged commit c92693b into apache:master Oct 3, 2022
@linghengqian linghengqian deleted the graalvm-native-image branch October 3, 2022 15:23
@linghengqian linghengqian mentioned this pull request Oct 5, 2022
Closed
7 tasks
@linghengqian linghengqian mentioned this pull request Jun 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taojintianxia taojintianxia taojintianxia left review comments

@terrymanu terrymanu terrymanu approved these changes

Assignees

No one assigned

Labels

type: build

Projects

None yet

Milestone

5.2.1

Development

Successfully merging this pull request may close these issues.

4 participants

@linghengqian @codecov-commenter @taojintianxia @terrymanu