Skip to content

[ISSUE #29] Store the broker configuration and jvm parameters in configmap #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
liuruiyiyang merged 3 commits into from
Aug 28, 2020
Merged

[ISSUE #29] Store the broker configuration and jvm parameters in configmap #25

liuruiyiyang merged 3 commits into from
Aug 28, 2020

Conversation

@zhihui921016
Copy link
Contributor

@zhihui921016 zhihui921016 commented Apr 10, 2020

Before the configuration of broker is wrote in the image, it is not convenient to modify it. It is more reasonable to store it in configmap.

@liuruiyiyang
Copy link
Contributor

liuruiyiyang commented Jul 5, 2020 •
edited
Loading

Thanks for you contribution! Could you please add some docs about the usage of the ConfigMap for the users? :) Thus we could test it conveniently.

@vongosling
Copy link
Member

vongosling commented Jul 22, 2020

@zhihui921016 ping, could you help to resolve the conflict and connect this pr with a concrete issue? May be "Pull Request naming conventions" in here(https://docs.google.com/document/d/1fo_Z4_nUOyykkmQOE2kEmxcLwhhFiQENQwQiy852XUM/edit#heading=h.9hxidqv8pyyk) will help you.

@zhihui921016 zhihui921016 changed the title Store the broker configuration and jvm parameters in configmap [ISSUE #29] Store the broker configuration and jvm parameters in configmap Jul 23, 2020
@zhihui921016
Copy link
Contributor Author

zhihui921016 commented Jul 23, 2020

@liuruiyiyang @vongosling Thanks for your suggestions. Actually I provide a demo in the example dir. You can get the usage about ConfigMap.

liuruiyiyang
liuruiyiyang reviewed Jul 28, 2020
View reviewed changes
@liuruiyiyang
Copy link
Contributor

liuruiyiyang commented Aug 17, 2020

Hi, @zhihui921016
Since this PR has some conflicts with the master branch I am wondering if you could solve them or should a new PR be proposed.

@zhihui921016
Copy link
Contributor Author

zhihui921016 commented Aug 28, 2020

Hi, @zhihui921016
Since this PR has some conflicts with the master branch I am wondering if you could solve them or should a new PR be proposed.

Thanks for the reminder, fixed

liuruiyiyang
liuruiyiyang approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@liuruiyiyang liuruiyiyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuruiyiyang liuruiyiyang merged commit 7282b98 into apache:master Aug 28, 2020
@liuruiyiyang liuruiyiyang added the enhancement New feature or request label Aug 28, 2020
@liuruiyiyang liuruiyiyang mentioned this pull request Aug 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liuruiyiyang liuruiyiyang liuruiyiyang approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhihui921016 @liuruiyiyang @vongosling