Skip to content

[ISSUE #121] feat(core): Support ServiceAccountName for broker/nameserver/console in OpenShift #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
caigy merged 6 commits into from
Jul 29, 2022
Merged

[ISSUE #121] feat(core): Support ServiceAccountName for broker/nameserver/console in OpenShift #106

caigy merged 6 commits into from
Jul 29, 2022

Conversation

@shangjin92
Copy link
Contributor

@shangjin92 shangjin92 commented Jul 1, 2022

Add setting of ServiceAccountName to support installment on OpenShift. Because in OpenShift, it need to set ServiceAccountName explicitly.

feat(core): Support ServiceAccountName for broker/nameserver/console
b160ad4 
Add setting of ServiceAccountName to support installment on OpenShift, because in OpenShift, it will set ServiceAccountName explicitly.
caigy
caigy requested changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@caigy caigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls also resolve conflits.

@caigy
Copy link
Contributor

caigy commented Jul 28, 2022

@shangjin92 Pls submit an issue and relate this pr to it.

jim.sj added 5 commits July 28, 2022 22:20
fix:using little camel cased ServiceAccountName in json tag
dadef4c
Merge branch 'master' of https://github.com/shangjin92/rocketmq-operator
acd9f1f 
 into feature/support-serviceaccount-for-openshift

# Conflicts:
#	pkg/controller/broker/broker_controller.go
Merge branch 'master' of https://github.com/shangjin92/rocketmq-operator
ddbf0d9 
 into feature/support-serviceaccount-for-openshift

# Conflicts:
#	pkg/controller/broker/broker_controller.go
Merge branch 'master' of https://github.com/shangjin92/rocketmq-operator
1c0f9b7 
 into feature/support-serviceaccount-for-openshift

# Conflicts:
#	pkg/controller/broker/broker_controller.go
Merge branch 'master' of https://github.com/shangjin92/rocketmq-operator
db6764e 
 into feature/support-serviceaccount-for-openshift

# Conflicts:
#	pkg/controller/broker/broker_controller.go
@shangjin92
Copy link
Contributor Author

shangjin92 commented Jul 28, 2022

fix #121

@caigy caigy changed the title feat(core): Support ServiceAccountName for broker/nameserver/console in OpenShift [ISSUE #121] feat(core): Support ServiceAccountName for broker/nameserver/console in OpenShift Jul 29, 2022
@ShannonDing ShannonDing linked an issue Jul 29, 2022 that may be closed by this pull request
Cannot support to set ServiceAccountName when deployed on OpenShift. #121
Closed
caigy
caigy approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@caigy caigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caigy caigy merged commit 859841f into apache:master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caigy caigy caigy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot support to set ServiceAccountName when deployed on OpenShift.

2 participants

@shangjin92 @caigy