Skip to content

[Improve] Set dlq producerName#1137

Merged
RobertIndie merged 4 commits into
apache:masterfrom
crossoverJie:set-dlq-producername
Nov 24, 2023
Merged

[Improve] Set dlq producerName#1137
RobertIndie merged 4 commits into
apache:masterfrom
crossoverJie:set-dlq-producername

Conversation

@crossoverJie

Copy link
Copy Markdown
Member

Motivation

To keep consistent with the Java client.

Releted PR: apache/pulsar#21589

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Set DLQ producerName %s-%s-DLQ

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (yes)
  • The wire protocol: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@RobertIndie RobertIndie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@RobertIndie RobertIndie added this to the v0.12.0 milestone Nov 23, 2023
@RobertIndie RobertIndie merged commit 067dca1 into apache:master Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants