Consumer can getValue return null #4848
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
run Integration Tests |
Contributor
Author
|
run java8 tests |
Contributor
Author
|
run Integration Tests |
Contributor
Author
|
run java8 tests |
sijie
requested changes
Jul 30, 2019
| } | ||
| } else { | ||
| return schema.decode(getData()); | ||
| if (getData().length == 0) { |
Member
There was a problem hiding this comment.
I think the fix here is a bit problematic. because an application can produce a zero-length bytes array. Can we find a way to differentiate a zero-length bytes payload from a null payload?
Member
There was a problem hiding this comment.
we should use metadata to store the null payload.
Member
|
@congbobo184 are you still working on this change? |
Contributor
Author
|
I am not working on it.It can be moved to the next version. |
1 task
Contributor
|
Close this PR since #6379 has fixed the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Consumer can getValue return null
fix the #4803
Verifying this change
Add the tests for it
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (yes)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)
Documentation
Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation