Skip to content

[fix][broker][branch-3.3] Disable broken ExtensibleLoadManager tests and add closeInternalTopics in follower monitor #24557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lhotari merged 1 commit into from
Jul 25, 2025
Merged

[fix][broker][branch-3.3] Disable broken ExtensibleLoadManager tests and add closeInternalTopics in follower monitor #24557

lhotari merged 1 commit into from
Jul 25, 2025

Conversation

@heesung-sohn
Copy link
Contributor

@heesung-sohn heesung-sohn commented Jul 25, 2025 •
edited
Loading

…

Motivation

Disabled the broken tests from ExtensibleLoadManager to unblock 3.3 release. We could fix the broken tests later(but I don't think it is worth to fix them, as they should work better in the mainline branch). I believe we can disable them to unblock the release.

Modifications

  • added this logic closeInternalTopics in the monitor thread to clean internal topics from the follower in case they are loaded

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions
Copy link

github-actions bot commented Jul 25, 2025

@heesung-sn Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Jul 25, 2025
@heesung-sohn heesung-sohn changed the title [fix][broker] fix ExtensibleLoadManager test failures and add closeInternalTopics in follower monitor [fix][broker] Disable broken ExtensibleLoadManager tests and add closeInternalTopics in follower monitor Jul 25, 2025
@lhotari lhotari changed the title [fix][broker] Disable broken ExtensibleLoadManager tests and add closeInternalTopics in follower monitor [fix][broker][branch-3.3] Disable broken ExtensibleLoadManager tests and add closeInternalTopics in follower monitor Jul 25, 2025
lhotari
lhotari approved these changes Jul 25, 2025
View reviewed changes
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you @heesung-sn!

@lhotari lhotari merged commit ca9bc64 into apache:branch-3.3 Jul 25, 2025
78 of 87 checks passed
@heesung-sohn heesung-sohn deleted the branch-3.3-fix branch July 26, 2025 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhotari lhotari lhotari approved these changes

Assignees

No one assigned

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@heesung-sohn @lhotari