[fix][broker] Fix duplicate increment of ADD_OP_COUNT_UPDATER in OpAddEntry #24502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@3pacccccc Please add the following content to your PR description and select a checkbox: |
nodece
approved these changes
Jul 11, 2025
…micConfigurationTopicAutoCreationPartitioned (apache#24505)
Technoboy-
approved these changes
Jul 11, 2025
dao-jun
reviewed
Jul 11, 2025
|
|
||
| // internally asyncAddEntry() will take the ownership of the buffer and release it at the end | ||
| addOpCount = ManagedLedgerImpl.ADD_OP_COUNT_UPDATER.incrementAndGet(ml); | ||
| addOpCount = ManagedLedgerImpl.ADD_OP_COUNT_UPDATER.get(ml); |
Member
There was a problem hiding this comment.
How about remove this line instead of ManagedLedgerImpl.ADD_OP_COUNT_UPDATER.get(ml) ?
OpAddEntry.addOpCount was already set in OpAddEntry.createOpAddEntryNoRetainBuffer
Contributor
Author
There was a problem hiding this comment.
Yes, this makes more sense. Thanks for pointing it out. I've already removed it,please take a look again
…testDynamicConfigurationTopicAutoCreationPartitioned (apache#24505)" This reverts commit e4de9c0.
…ache#24501)" This reverts commit 0bdce23.
…o all test (apache#24492)" This reverts commit 13e0a7b.
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, when adding a message to a ledger,
ManagedLedgerImpl.ADD_OP_COUNT_UPDATERis incremented twice:createOpAddEntryNoRetainBuffer()when creating theOpAddEntryOpAddEntry.initiate()This double increment leads to incorrect operation counting and potential metric inaccuracies.
here's the example I've tested on my local.
Modifications
OpAddEntry.initiate()fromincrementAndGet()toget()to prevent duplicate countingtestAddOpCountWithMessageAdd()to verify the correct increment behaviorVerifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: 3pacccccc#11