[improve][broker] PIP-315: Configurable max delay limit for delayed delivery #21798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KevinLiLu Please add the following content to your PR description and select a checkbox: |
lhotari
reviewed
Dec 24, 2023
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Producer.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Producer.java
Outdated
Show resolved
Hide resolved
lhotari
approved these changes
Jan 11, 2024
Member
lhotari
left a comment
There was a problem hiding this comment.
LGTM. Great work. Thanks for the contribution!
I added an "optional" comment about using java.time.Duration for the public API.
...-admin-api/src/main/java/org/apache/pulsar/common/policies/data/DelayedDeliveryPolicies.java
Show resolved
Hide resolved
Jason918
reviewed
Jan 16, 2024
pulsar-client-tools-test/src/test/java/org/apache/pulsar/admin/cli/PulsarAdminToolTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: JiangHaiting <jianghaiting@apache.org>
lhotari
approved these changes
Jan 18, 2024
Contributor
Author
|
Hi @lhotari, apologies for the churn but could you re-trigger the workflow? I missed the maxDelay parameter in a couple Cmd classes. |
Member
|
@KevinLiLu Please resolve the conflicts |
Contributor
Author
@dao-jun Thanks for pointing this out. I have resolved the conflict. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #21798 +/- ##
============================================
+ Coverage 73.60% 73.65% +0.05%
- Complexity 32411 32456 +45
============================================
Files 1861 1861
Lines 138674 138724 +50
Branches 15182 15188 +6
============================================
+ Hits 102070 102180 +110
+ Misses 28702 28660 -42
+ Partials 7902 7884 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
|
@lhotari does all the conversations resolved? |
Member
|
LGTM |
4 tasks
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIP-315: Configurable max delay limit for delayed delivery (https://github.com/apache/pulsar/blob/master/pip/pip-315.md)
Motivation
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: