[improve][pip] PIP-318: Don't retain null-key messages during topic compaction#21541
Merged
Conversation
Member
|
+1 (binding)
Best,
Mattison
… On Nov 13, 2023, at 15:03, Qiang Zhao ***@***.***> wrote:
@mattisonchao commented on this pull request.
In pip/pip-318.md <#21541 (comment)>:
> +In summary, I don't think we should retain null-key messages during topic compaction.
+
+# Goals
+
+# High Level Design
+
+In order to avoid introducing break changes to release version, we need to add a configuration to control whether to retain null-key messages during topic compaction.
+If the configuration is true, we will retain null-key messages during topic compaction, otherwise, we will not retain null-key messages during topic compaction.
+
+## Public-facing Changes
+
+### Configuration
+
+Add config to broker.conf
+```properties
+compactionRemainNullKey=false
Agree.
—
Reply to this email directly, view it on GitHub <#21541 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AR2NWCYBK5ORHVYUB35QX6LYEHA4FAVCNFSM6AAAAAA7CLQEYCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMRWGYZTOMZYGY>.
You are receiving this because you are subscribed to this thread.
|
Member
Author
|
Merge this PIP, since the vote has been approved: https://lists.apache.org/thread/36rfmvz5rchgnvqb2wcq4wb64k6st90p |
Merged
5 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Modifications
Start a PIP: Don't retain null-key messages during topic compaction
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: