Skip to content

Create a producerName field for DeadLetterPolicy#21493

Closed
crossoverJie wants to merge 4 commits into
apache:masterfrom
crossoverJie:fix-issue-21441
Closed

Create a producerName field for DeadLetterPolicy#21493
crossoverJie wants to merge 4 commits into
apache:masterfrom
crossoverJie:fix-issue-21441

Conversation

@crossoverJie

Copy link
Copy Markdown
Member

Fixes #21441

Motivation

Add producerName for dead letter producer, easier to locate problems.

Modifications

public class DeadLetterPolicy {

    /**
     * Name of the dead letter producer name.
     */
	private String producerName;
}

Add a new field producerName in DeadLetterPolicy class.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: crossoverJie#15

@github-actions github-actions Bot added the doc-required Your PR changes impact docs and you will update later. label Nov 1, 2023
Comment on lines +63 to +67

/**
* Name of the dead letter producer name.
*/
private String producerName;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a change for the public API. We need a PIP to get approved to add this field.

@crossoverJie

Copy link
Copy Markdown
Member Author

Close by #21589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-required Your PR changes impact docs and you will update later.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DeadLetterPolicy supports specifying producerName

2 participants