Skip to content

[improve][misc] PIP-265: Delete wiki/proposals and define new process in new folder#20418

Merged
codelipenghui merged 16 commits into
apache:masterfrom
asafm:new-pip-process
May 30, 2023
Merged

[improve][misc] PIP-265: Delete wiki/proposals and define new process in new folder#20418
codelipenghui merged 16 commits into
apache:masterfrom
asafm:new-pip-process

Conversation

@asafm

@asafm asafm commented May 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Delete wiki/proposals and define new process in new folder named pip.

PIP: #20207

Motivation

Per the PIP, we're redefining the PIP process

Modifications

  • Added pip folder
  • Added README to the PIP folder, describing the process, and containing links to find PIPs, whether historical or not.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label May 28, 2023
@asafm asafm mentioned this pull request May 28, 2023
Closed
@codelipenghui codelipenghui added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label May 29, 2023
@github-actions github-actions Bot removed the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label May 29, 2023
visortelle
visortelle reviewed May 29, 2023
View reviewed changes
Comment thread pip/README.md Outdated
visortelle
visortelle reviewed May 29, 2023
View reviewed changes
Comment thread pip/TEMPLATE.md Outdated
visortelle
visortelle reviewed May 29, 2023
View reviewed changes
Comment thread pip/TEMPLATE.md Outdated
visortelle
visortelle reviewed May 29, 2023
View reviewed changes
Comment thread pip/TEMPLATE.md Outdated
visortelle
visortelle reviewed May 29, 2023
View reviewed changes
Comment thread pip/TEMPLATE.md Outdated
visortelle
visortelle reviewed May 29, 2023
View reviewed changes
Comment thread pip/TEMPLATE.md Outdated
visortelle
visortelle reviewed May 29, 2023
View reviewed changes
Comment thread pip/TEMPLATE.md Outdated
visortelle
visortelle reviewed May 29, 2023
View reviewed changes
Comment thread pip/TEMPLATE.md Outdated
visortelle
visortelle reviewed May 29, 2023
View reviewed changes
Comment thread pip/TEMPLATE.md Outdated
visortelle
visortelle reviewed May 29, 2023
View reviewed changes
Comment thread pip/TEMPLATE.md Outdated
visortelle
visortelle reviewed May 29, 2023
View reviewed changes
Comment thread pip/TEMPLATE.md Outdated
visortelle
visortelle reviewed May 29, 2023
View reviewed changes
Comment thread pip/TEMPLATE.md Outdated
asafm and others added 8 commits May 29, 2023 14:58
@asafm @visortelle
Update pip/README.md
b9ab9e7 
Co-authored-by: Kiryl Valkovich <visortelle@gmail.com>
@asafm @visortelle
Update pip/TEMPLATE.md
e99c7ce 
Co-authored-by: Kiryl Valkovich <visortelle@gmail.com>
@asafm @visortelle
Update pip/TEMPLATE.md
1856b3c 
Co-authored-by: Kiryl Valkovich <visortelle@gmail.com>
@asafm @visortelle
Update pip/TEMPLATE.md
8fb2494 
Co-authored-by: Kiryl Valkovich <visortelle@gmail.com>
@asafm @visortelle
Update pip/TEMPLATE.md
d92d8ed 
Co-authored-by: Kiryl Valkovich <visortelle@gmail.com>
@asafm @visortelle
Update pip/TEMPLATE.md
e76f91a 
Co-authored-by: Kiryl Valkovich <visortelle@gmail.com>
@asafm @visortelle
Update pip/TEMPLATE.md
22a2243 
Co-authored-by: Kiryl Valkovich <visortelle@gmail.com>
@asafm @visortelle
Update pip/TEMPLATE.md
7a705b1 
Co-authored-by: Kiryl Valkovich <visortelle@gmail.com>
asafm and others added 4 commits May 29, 2023 15:00
@asafm @visortelle
Update pip/TEMPLATE.md
b6b8af8 
Co-authored-by: Kiryl Valkovich <visortelle@gmail.com>
@asafm @visortelle
Update pip/TEMPLATE.md
a958c29 
Co-authored-by: Kiryl Valkovich <visortelle@gmail.com>
@asafm @visortelle
Update pip/TEMPLATE.md
d479db7 
Co-authored-by: Kiryl Valkovich <visortelle@gmail.com>
@asafm @visortelle
Update pip/TEMPLATE.md
759e7a7 
Co-authored-by: Kiryl Valkovich <visortelle@gmail.com>
@asafm

asafm commented May 29, 2023

Copy link
Copy Markdown
Contributor Author

@codelipenghui Do we need more reviewers or can we merge?

@codelipenghui codelipenghui merged commit fb05c45 into apache:master May 30, 2023
@asafm asafm deleted the new-pip-process branch May 30, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@visortelle visortelle visortelle left review comments

@codelipenghui codelipenghui codelipenghui approved these changes

Assignees

@asafm asafm

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@asafm @visortelle @codelipenghui